Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show branch preview banner on every (non-master) page #183

Open
andylolz opened this issue Nov 14, 2017 · 0 comments
Open

Show branch preview banner on every (non-master) page #183

andylolz opened this issue Nov 14, 2017 · 0 comments

Comments

@andylolz
Copy link
Contributor

andylolz commented Nov 14, 2017

E.g. it’s not currently shown on http://org-id.guide/results .

I think it’s fine to use cookies for branch previewing – it’s probably the correct way to do it. But when I’m previewing a branch and I want to test how the new codelist appears in the results, it’s not obvious that the cookie is still set because the preview banner disappears. It would be good if the banner were there on every page.

Related to this, it would probably be preferable to use middleware to inject the branch variable into templates, rather than having to handle it for each view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant