New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Category is sometimes set to "-" in download.xml #212

Open

andylolz opened this issue Jan 18, 2019 · 0 comments

Contributor

andylolz commented Jan 18, 2019

Relevant code:

org-ids/prefix_finder/frontend/views.py

Lines 604 to 607 in 72a6993

    
           if entry.get('coverage'): 
        
               ET.SubElement(item, "category").text = entry['coverage'][0] 
        
           else: 
        
               ET.SubElement(item, "category").text = '-'

I guess this is because the country code used isn’t on ISO 3166. In these cases, it would be preferable to either:

Use an empty string instead of "-", or
Use the country code provided (e.g. XM; XI) because as far as IATI is concerned that’s still fine (given the Country codelist is incomplete).

andylolz mentioned this issue

OrganisationRegistrationAgency refers to non-existent categories IATI/IATI-Codelists#92

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment