Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsoninclude: Hide select box for single directives #40

Open
duncandewhurst opened this issue Sep 14, 2022 · 3 comments
Open

jsoninclude: Hide select box for single directives #40

duncandewhurst opened this issue Sep 14, 2022 · 3 comments

Comments

@duncandewhurst
Copy link

The select box is useful when there are consecutive directives but useless when there is only one directive.

@jpmckinney
Copy link
Contributor

I don't think the directive creates the select box, but rather JS code, like this for OCDS. Perhaps the project with the select box has incorrect logic.

@duncandewhurst
Copy link
Author

duncandewhurst commented Mar 1, 2024

Yes, I think the Javascript files linked in the documentation for the directive need to be updated with the correct logic. At least, the examples on that page show a selection box even when there is only one directive.

Edit: For future reference, I created this issue whilst working on the OFDS documentation.

@jpmckinney
Copy link
Contributor

Aha - I might have simply fixed this for OCDS. Feel free to copy that code into this project (with maybe a link in a comment, so it's easy to check if the source has changed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants