Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dumped config of guide spreadsheets to speed up get_data #17

Open
odscjames opened this issue Jul 7, 2020 · 0 comments
Open

Use dumped config of guide spreadsheets to speed up get_data #17

odscjames opened this issue Jul 7, 2020 · 0 comments

Comments

@odscjames
Copy link
Contributor

odscjames commented Jul 7, 2020

Current function get data can be slow when extracting many fields.

One reason for this is the code is actually working with 2 Excel sheets at the same time, the input and the guide.

Change function so that it uses the dumped config JSON blob from #16 instead of the guide.

Now function only works with 1 Excel sheet and is hopefully much faster (we are assuming here working with an excel spreadsheet is much slower than working with a small JSON blob where all data is already in the correct format, but that is probably a safe assumption)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant