Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

questions about transformations #24

Closed
MaicsCYB opened this issue Jul 3, 2022 · 8 comments
Closed

questions about transformations #24

MaicsCYB opened this issue Jul 3, 2022 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@MaicsCYB
Copy link

MaicsCYB commented Jul 3, 2022

  1. I cannot understand the details about transformations, I think the formulation wants to get E_g2c. so, why not use 'R_gv@E' instead of 'inv(R_vg)@ E @R_vg@R_gc'?

  2. which is the correct coordinate system for 3d lane points?
    image
    image

thanks!

@ChonghaoSima
Copy link
Collaborator

  1. the transformation is largely following GenLaneNet. You can have a try on R_gv@E method and see if there's any improvement.
  2. sorry, that was a typo in OpenLane repo. We'll fix it. The correct coordinate system is vehicle coordinates.

@Mollylulu
Copy link

for this step

 cam_extrinsics[:3, :3] = np.matmul(np.matmul(np.matmul(np.linalg.inv(R_vg),cam_extrinsic[:3, :3]),R_vg), R_gc)

could you help me figure out, what is this inv(R_vg) @ E @ R_vg @ R_gc doing? To my mind, E_g2c is final target here, am I right? But I still can not understand each step transformation in above line. Could you give some interpretation that would be very appreciated :) thanks !

@nikhil-nakhate
Copy link

same question as above

@presmann
Copy link

presmann commented Aug 23, 2022

@ChonghaoSima it seems quite strange that the annotations are in the vehicle_coordinate system. Specifically, the z part of the annotations tends to be negative most of the times. it seems to in the camera coordinates after all.
For example, in lane3d_1000/training/segment-15832924468527961_1564_160_1584_160_with_camera_labels/150767882737686600.json the first lane is (labels_dict is dictionary of the loaded json)

min(lanes_visualization_obj.labels_dict['lane_lines'][0]['xyz'][2])
Out[15]: -3.8558186921526554
max(lanes_visualization_obj.labels_dict['lane_lines'][0]['xyz'][2])
Out[16]: -2.2029994863655915

And the 2nd one is:

 min(lanes_visualization_obj.labels_dict['lane_lines'][1]['xyz'][2])
Out[18]: -2.4630904216158926
max(lanes_visualization_obj.labels_dict['lane_lines'][0]['xyz'][2])
Out[19]: -2.2029994863655915

and the third one is:

min(lanes_visualization_obj.labels_dict['lane_lines'][2]['xyz'][2])
Out[20]: -3.8966073247935045
max(lanes_visualization_obj.labels_dict['lane_lines'][2]['xyz'][2])
Out[21]: -2.4456845933203346

@RicardLee
Copy link
Contributor

Please refer to https://github.com/OpenPerceptionX/OpenLane/issues/24. It should solve your questions. The annotations are under the Waymo camera coordinate (The typo has been updated in https://github.com/OpenPerceptionX/OpenLane/blob/main/anno_criterion/Lane/README.md).

@ChonghaoSima ChonghaoSima reopened this Sep 13, 2022
@ChonghaoSima ChonghaoSima added documentation Improvements or additions to documentation good first issue Good for newcomers labels Sep 13, 2022
@RicardLee
Copy link
Contributor

We will close this issue, if you still have the same questions, please reopen this.

@usherbob
Copy link

It should solve your questions. The annotations are under the Waymo camera coordinate (The typo has been updat

Seems the link is invalid, may you update the explanation of this issue?

@ilnehc
Copy link
Collaborator

ilnehc commented May 19, 2023

@usherbob Just change OpenPerceptionX to OpenDriveLab: https://github.com/OpenDriveLab/OpenLane/blob/main/anno_criterion/Lane/README.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

9 participants