Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

standard choices for sec. in rate #1216

Closed
huss opened this issue Apr 9, 2024 · 5 comments · Fixed by #1388
Closed

standard choices for sec. in rate #1216

huss opened this issue Apr 9, 2024 · 5 comments · Fixed by #1388
Assignees
@AchsahJojo
Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-enhancement This issues tracks a potential improvement to the software
Milestone
2.x

Comments

@huss
Copy link
Member

huss commented Apr 9, 2024

Is your feature request related to a problem? Please describe.

On unit create/edit, there is a box to enter the Sec. in Rate as a number. It would be nice if the admin had a list of standard values and also could enter a custom value if desired.

Describe the solution you'd like

The list of standard values would be: Per Second (1), Per Minute (60) and Per Hour (3600).

The UI to allow this list and a custom value is unclear. OED has places where there are fixed value menus using an enum but not then allowing a custom value.

Describe alternatives you've considered

Leave as is if this is difficult to do.

Additional context

None.
@huss huss added t-enhancement This issues tracks a potential improvement to the software p-low-priority i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. labels Apr 9, 2024
@huss huss added this to the 1.x milestone Apr 9, 2024
@huss
Copy link
Member Author

huss commented May 31, 2024 •
edited
Loading

PR #1249 allows the bar width to be entered via check boxes and text. OED should probably be consistent in the interface so modeling this after that would be good.

Update: The check boxes are gone and it was decided to use a drop down menu. That is the wave of the OED future :-)

@AchsahJojo
Copy link
Contributor

Me and my Team are working on this !

@SalvadorN323
Copy link

Hello! Is #1216 available to be worked on? If so, my team and I can look into it!

@AchsahJojo
Copy link
Contributor

AchsahJojo commented Oct 27, 2024 via email

@huss
Copy link
Member Author

huss commented Oct 27, 2024

Hello! Is #1216 available to be worked on? If so, my team and I can look into it!

@SalvadorN323 Let me confirm that this issue is still assigned (as shown above) and is not available to work on. If you want help in finding another issue then let me know.

This was referenced Nov 16, 2024
Closed
Merged
@huss huss closed this as completed in #1388 Jan 8, 2025
huss added a commit that referenced this issue Jan 8, 2025
@huss
Merge pull request #1388 from gyordong/1188sort
355bbb7 
Custom rate and named standard rate for units (Issue #1216)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AchsahJojo AchsahJojo

Labels
i-good-first-issue This issue is probably a good starting point for people new to coding or the OED project. p-low-priority t-enhancement This issues tracks a potential improvement to the software
Projects
None yet
Milestone
2.x
3 participants
@huss @AchsahJojo @SalvadorN323