Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: OwnPV-Outlook #108

Open
5 of 16 tasks
sbecker-iee opened this issue Dec 20, 2022 · 4 comments
Open
5 of 16 tasks

Review: OwnPV-Outlook #108

sbecker-iee opened this issue Dec 20, 2022 · 4 comments
Assignees
Labels
review Data and Metadata review

Comments

@sbecker-iee
Copy link

sbecker-iee commented Dec 20, 2022

Issue description

I'm submitting an open dataset with a corresponding OEMetadata string for review.
The dataset shows the results from project "Fh IEE OwnPV-Outlook" ("PV self-supply as a sustainable, robust and efficient element of the future energy system") of Fraunhofer IEE. It contains a total of 4 different input tables as well as 8 output tables for each of the 3 scenarios.

Names of the three different scenarios:

  1. fh_iee_ownpv_base_scenario (Scenario with an increasing share of housing with PV self-supply systems)
  2. fh_iee_ownpv_25pc_less_self_supply (Scenario with 25% less PV self-supply systems compared to the base scenario)
  3. fh_iee_ownpv_25pc_more_self_supply (Scenario with 25% more PV self-supply systems compared to the base scenario)

Input data (containing information for all of the three scenarios):

  1. fh_iee_ownpv_input_kuppelleistungen (Input data concerning net transfer capacities in all three scenarios)
  2. fh_iee_ownpv_input_laender (Input data concerning countries in all three scenarios)
  3. fh_iee_ownpv_input_rahmendaten (Input data concerning framework data in all three scenarios)
  4. fh_iee_ownpv_input_technologieparameter (Input data concerning technology parameters in all three scenarios)

Output data (each scenario has its own table for output data):

  1. fh_iee_ownpv_base_scenario_endenergie (Output data concerning the final energy demand in this specific scenario)
  2. fh_iee_ownpv_base_scenario_h2_erzeugung (Output data concerning the generation of hydrogen in Germany in this specific scenario)
  3. fh_iee_ownpv_base_scenario_interkonnektoren (Output data concerning the European interconnectors in this specific scenario)
  4. fh_iee_ownpv_base_scenario_speicher (Output data concerning different storage technologies in this specific scenario)
  5. fh_iee_ownpv_base_scenario_rahmendaten (Output data concerning general parameters in this specific scenario)
  6. fh_iee_ownpv_base_scenario_strom_bilanz (Output data concerning the electricity balance in this specific scenario)
  7. fh_iee_ownpv_base_scenario_strom_erzeugung (Output data concerning the electricity generation in this specific scenario)
  8. fh_iee_ownpv_base_scenario_zeitreihen (Selection of time series of different technologies in this specific scenario)
  9. fh_iee_ownpv_25pc_less_self_supply_endenergie (Output data concerning the final energy demand in this specific scenario)
  10. fh_iee_ownpv_25pc_less_self_supply_h2_erzeugung (Output data concerning the generation of hydrogen in Germany in this specific scenario)
  11. fh_iee_ownpv_25pc_less_self_supply_interkonnektoren (Output data concerning the European interconnectors in this specific scenario)
  12. fh_iee_ownpv_25pc_less_self_supply_speicher (Output data concerning different storage technologies in this specific scenario)
  13. fh_iee_ownpv_25pc_less_self_supply_rahmendaten (Output data concerning general parameters in this specific scenario)
  14. fh_iee_ownpv_25pc_less_self_supply_strom_bilanz (Output data concerning the electricity balance in this specific scenario)
  15. fh_iee_ownpv_25pc_less_self_supply_strom_erzeugung (Output data concerning the electricity generation in this specific scenario)
  16. fh_iee_ownpv_25pc_less_self_supply_zeitreihen (Selection of time series of different technologies in this specific scenario)
  17. fh_iee_ownpv_25pc_more_self_supply_endenergie (Output data concerning the final energy demand in this specific scenario)
  18. fh_iee_ownpv_25pc_more_self_supply_h2_erzeugung (Output data concerning the generation of hydrogen in Germany in this specific scenario)
  19. fh_iee_ownpv_25pc_more_self_supply_interkonnektoren (Output data concerning the European interconnectors in this specific scenario)
  20. fh_iee_ownpv_25pc_more_self_supply_speicher (Output data concerning different storage technologies in this specific scenario)
  21. fh_iee_ownpv_25pc_more_self_supply_rahmendaten (Output data concerning general parameters in this specific scenario)
  22. fh_iee_ownpv_25pc_more_self_supply_strom_bilanz (Output data concerning the electricity balance in this specific scenario)
  23. fh_iee_ownpv_25pc_more_self_supply_strom_erzeugung (Output data concerning the electricity generation in this specific scenario)
  24. fh_iee_ownpv_25pc_more_self_supply_zeitreihen (Selection of time series of different technologies in this specific scenario)

Metadata and data for review

Here are the links to my data incl metadata. Naming follows the pattern model_draft.project_nameofdata:

Data:
Input data:

  1. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_input_transcap
  2. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_input_laender
  3. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_input_rahmendaten
  4. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_input_techpars

Output data:

  1. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_base_scenario_endenergie
  2. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_base_scenario_h2_erzeugung
  3. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_base_scenario_interconn
  4. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_base_scenario_rahmendaten
  5. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_base_scenario_speicher
  6. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_base_scenario_strom_bilanz
  7. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_base_scenario_strom_erzeugung
  8. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_base_scenario_zeitreihen
  9. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_less_self_supply_endenergie
  10. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_less_self_supply_h2_erzeugung
  11. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_less_self_supply_interconn
  12. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_less_self_supply_rahmendaten
  13. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_less_self_supply_speicher
  14. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_less_self_supply_strom_bilanz
  15. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_less_self_supply_strom_erzeugung
  16. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_less_self_supply_zeitreihen
  17. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_more_self_supply_endenergie
  18. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_more_self_supply_h2_erzeugung
  19. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_more_self_supply_interconn
  20. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_more_self_supply_rahmendaten
  21. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_more_self_supply_speicher
  22. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_more_self_supply_strom_bilanz
  23. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_more_self_supply_strom_erzeugung
  24. https://openenergy-platform.org/dataedit/view/model_draft/fh_iee_ownpv_25pc_more_self_supply_zeitreihe

Workflow checklist

  1. GitHub
  • I have submitted this issue to have metadata and data review documented (Issue #NR)
  • Create a new review-branch and push OEMetadata to new branch (review/project_nameofdata#NR). If this step is too difficult, attach a file with the metadata as a comment in this issue and let the reviewer know.
  • The metadata is uploaded and available along with the data on the OEP -- is that sufficient?
  1. OEP
  • Upload data to the OEP in schema model_draft (see upload tutorial)
  • Link URL of data in this issue (model_draft.project_nameofdata) (see lists above)
  1. Start a Review
  • Start a pull request (PR) from review-branch to master
  • Assign a reviewer and get in contact
  1. Reviewer section
  • A reviewer starts working on the issue
  • Review data license
  • A reviewer finished working on this issue (and awarded a badge)
  • Update metadata on table
  • Data moved to its final schema
  • Add OEP tags to table
  • Merge PR and delete review-branch
  • Document final links of metadata and data in issue description
  • Close issue

Metadata and data for review

Here are the links to my data and metadata. Naming follows the pattern model_draft.project_nameofdata:
Metadata: https://github.com/OpenEnergyPlatform/data-preprocessing/blob/review/project_nameofdata/data-review/project_nameofdata.json
Data: https://openenergy-platform.org/dataedit/view/model_draft/project_nameofdata

Reviewed and published metadata and data

Final naming and location of the data and metadata after the review are as follows:
schema.tablename

@sbecker-iee sbecker-iee added the review Data and Metadata review label Dec 20, 2022
@sbecker-iee
Copy link
Author

I did not create a branch and upload the metadata because they are already uploaded and visible alongside the data (linked above). Is that sufficient?

@jh-RLI
Copy link
Contributor

jh-RLI commented Dec 20, 2022

We are currently in a transition phase from the github based review workflow to a review workflow that can be performed entirely on the OEP. From my point of view it is ok to store the metadata alongside the tables on the OEP and not here in the repository.

@u-mueller
Copy link

@jh-RLI, @christian-rli, this review is stale for a while, can you help settling it? Or has the new review process to be implemented first? Many Thanx!

@jh-RLI
Copy link
Contributor

jh-RLI commented Mar 22, 2023

I can´t help at the moment because my master thesis is about to be finished :) next month I will be back.
I think finalizing the fully functional review process in the OEP will still take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Data and Metadata review
Projects
None yet
Development

No branches or pull requests

5 participants