Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review/openfred_weatherdata #47

Open
8 tasks done
Ludee opened this issue Feb 6, 2020 · 22 comments · May be fixed by #48
Open
8 tasks done

review/openfred_weatherdata #47

Ludee opened this issue Feb 6, 2020 · 22 comments · May be fixed by #48
Assignees
Labels
curation annotation, maintenance and management of a data set documentation help wanted Extra attention is needed review Data and Metadata review v1.5.1 metadata created with version 1.5.1

Comments

@Ludee
Copy link
Member

Ludee commented Feb 6, 2020

Tables:
Note: metadata just differs at the "resources" key.

Additional tables:

Keep these tables?:

  • tables are in schema model_draft
    image

ToDo:

  • Create metadata @jh-RLI
  • Update metadata to v1.4.1 @jh-RLI
  • Check license info @ronny
  • Create UML @gnn -> @jh-RLI will provide a simple ERM diagram
  • Move into climate schema @Ludee
  • Update and release FRED-WAM @christian-rli
  • validate metadata using omi @jh-RLI
    - set "alignment": "horizontal" to "alignment": null to avoid omi validation error.
  • Add metadata to OEP openfred tables @jh-RLI
@Ludee Ludee added help wanted Extra attention is needed documentation curation annotation, maintenance and management of a data set labels Feb 6, 2020
Ludee added a commit that referenced this issue Feb 6, 2020
Ludee added a commit that referenced this issue Feb 6, 2020
@jh-RLI jh-RLI linked a pull request Feb 6, 2020 that will close this issue
@jh-RLI
Copy link
Contributor

jh-RLI commented Feb 6, 2020

@Ludee I think the openfred_powerplants is missing?

@jh-RLI
Copy link
Contributor

jh-RLI commented Feb 6, 2020

Spoke to @Ludee the powerplants table is not part of the weatherdata set and is not to be considered here.

@jh-RLI
Copy link
Contributor

jh-RLI commented Feb 6, 2020

The metadata-strings are created for all listed tables and linked in the issue description. The license information and a short description are still missing.

Ludee added a commit that referenced this issue Feb 19, 2020
@rpnaut
Copy link

rpnaut commented Mar 5, 2020

Regarding the openFRED weather data:

They have already an entry in the WDCC:

https://cera-www.dkrz.de/WDCC/ui/cerasearch/entry?acronym=coastDat3_COSMO-CLM_MERRA2

The description and key-words are defined already there:

Name: coastDat3_COSMO-CLM_MERRA2

Project: openFRED (open feed-in time series based on a Renewable Energy Database)

Summary: This is an atmospheric hindcast for Western Europe and the North Atlantic using COSMO-CLM version 5.0 with spectral nudging from 2002-2017. MERRA2 reanalysis data are used as forcing. Additionally transient and monthly aerosol data of the MACv2 climatology are prescribed. The model uses a rotated grid with 566 x 481 grid points and a grid point distance of 0.0625 degrees, the rotated North pole is located at 162.0 W, 39.25 N.
The published data excludes the sponge zone and have 526 x 441 grid points. In rotated coordinates the published simulation data extends from 22.64 W to 10.18 E, 11.2 S to 16.3 N, in geographical coordinates this corresponds to about 12 W to 30 E, 39 N to 60 N.

institution: Helmholtz-Zentrum Geesthacht, Institute of Coastal Research, Germany

source: int2lm_131101_2.00_clm4, COSMO-CLM5.0_clm14_aerosol_gust (available at DKRZ's LTA WDCC service)

contact: http://coastmod.hzg.de

originator: Ronny Petrik

crs: EPSG:4326 ContactDr. Ronny Petrik (✉ [email protected] )

Keyword(s): COSMO-CLM, hindcast, MERRA2, openSource, regional modelling, renewable energy

@rpnaut
Copy link

rpnaut commented Mar 5, 2020

Bei den Attributen in Temporal stimmt was nicht: End ist 2018 und Resolution ist minimal 15 Minuten und maximal 60 Minuten.

"temporal": {
29 "referenceDate": null,
30 "timeseries": {
31 "start": "2002",
32 "end": "2017",
33 "resolution": "30 min",
34 "alignment": "horizontal",
35 "aggregationType": null
36 }
37 },

@rpnaut
Copy link

rpnaut commented Mar 5, 2020

Die Lizenzen bei den Sources sind alle auch meiner Meinung nach NULL. Public Domain und Vertragsvereinbarungen können als Lizenzen nicht eingestuft werden.

@Ludee
Copy link
Member Author

Ludee commented Apr 30, 2020

Project: openFRED (open feed-in time series based on a Renewable Energy Database)

The correct project name is open_FRED

@Ludee
Copy link
Member Author

Ludee commented Apr 30, 2020

Die Lizenzen bei den Sources sind alle auch meiner Meinung nach NULL. Public Domain und Vertragsvereinbarungen können als Lizenzen nicht eingestuft werden.

https://github.com/OpenEnergyPlatform/data-preprocessing/blob/review/openfred/data-review/climate.openfred_weatherdata_locations.json#L38-L151

The metadata point sources/licenses means term of use and not the juridical license. Thus if it is licensed under PD/CC0 or other "quasi-licenses" like GeoNutzV it should be documented. It's not important if it is a real license or not.

@Ludee
Copy link
Member Author

Ludee commented Apr 30, 2020

Keyword(s): COSMO-CLM, hindcast, MERRA2, openSource, regional modelling, renewable energy

It's not Open Source nor open-source. But never ever openSource. The source code to generate the weather data is not licensed with an open license!
It is Open Data!

@Ludee
Copy link
Member Author

Ludee commented Apr 30, 2020

source: int2lm_131101_2.00_clm4, COSMO-CLM5.0_clm14_aerosol_gust (available at DKRZ's LTA WDCC service)

What is this? Is this an additional source?

Ludee added a commit that referenced this issue Apr 30, 2020
@rpnaut
Copy link

rpnaut commented May 1, 2020

Okay. At first we adapt the project explanation at WDCC regarding project name and ending of simulation.

At second, we will adapt the keyword "openSource" - huge mistake and never checked by myself.

@rpnaut
Copy link

rpnaut commented May 1, 2020

Die Attribution
„coastDat3_COSMO-CLM_MERRA2 - open_FRED Weatherdata“ © Helmholtz-Zentrum Geesthacht | ODC-By-1.0"

ist korrekt.

@rpnaut
Copy link

rpnaut commented May 1, 2020

I cannot push to the repository. Please try to get this working with my account rpnaut.

As long as this is not fixed, I keep the files on local devices.

@rpnaut
Copy link

rpnaut commented May 3, 2020

I have to say that I do not know the difference between all the json-files:

openfred_flags -> review metadata
openfred_locations -> review metadata
openfred_series -> review metadata
openfred_timespans -> review metadata
openfred_variables -> review metadata

So, I only start to review the first one.

@rpnaut
Copy link

rpnaut commented May 3, 2020

source: int2lm_131101_2.00_clm4, COSMO-CLM5.0_clm14_aerosol_gust (available at DKRZ's LTA WDCC service)

This is the hint on the source code (version of the model).

@Ludee
Copy link
Member Author

Ludee commented Mar 24, 2021

Thanks for the reminder @Bachibouzouk
This review should be finalized.
@gnn @christian-rli can you help?

@jh-RLI
Copy link
Contributor

jh-RLI commented Apr 23, 2021

I have to say that I do not know the difference between all the json-files:

openfred_flags -> review metadata
openfred_locations -> review metadata
openfred_series -> review metadata
openfred_timespans -> review metadata
openfred_variables -> review metadata

So, I only start to review the first one.

That's fine, the only difference is the data model description at the key "resources": ....). Each table is described with technical details, there is also a description for each field/column. This might be worth a review. I will use the current state for now.

@jh-RLI
Copy link
Contributor

jh-RLI commented Apr 23, 2021

The OEP metadata validation tool omi does not allow "alignment":"horizontal". Just "left", "middle" or "right" are valid ATM. What would be the appropriate value?

"temporal": {
        .....
        "timeseries": {
            ....
            "alignment": "horizontal",
           .....
        }

@jh-RLI
Copy link
Contributor

jh-RLI commented Apr 23, 2021

There is no "publicationDate": null
Edit: Set to date of this issue (2020-02-06)

@jh-RLI
Copy link
Contributor

jh-RLI commented May 6, 2021

OEMetadata is now available on each open_FRED table (scroll down to "Metadata Information"):
openfred_flags
openfred_locations
openfred_series
openfred_timespans
openfred_variables

Also added similar metadata to the additional tables:
openfred_feedin_wind_2016
openfred_timeseries_ch

Note:

I had to use my backend DB access to update the Metadata since there are no permissions set on the tables. I'm not sure who created the tables? Please create an "open_FRED" user group on the OEP and add all contributor. Then the table owner needs to set the group to the table permissions. By that we can update the metadata and more easy next time.

You can create the goup (add new member) and add permissions to a table using the OEP website (oep account required).

@christian-rli

@Ludee
Copy link
Member Author

Ludee commented May 11, 2021

Thanks and rights are granted.

@Ludee
Copy link
Member Author

Ludee commented May 11, 2021

The table with the variables is missing the units. That's an important information. @gnn

https://openenergy-platform.org/dataedit/view/climate/openfred_variables

@steull steull added review Data and Metadata review v1.4 metadata created with version 1.4 labels Mar 1, 2022
steull added a commit that referenced this issue Jul 4, 2022
@steull steull added v1.5.1 metadata created with version 1.5.1 and removed v1.4 metadata created with version 1.4 labels Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
curation annotation, maintenance and management of a data set documentation help wanted Extra attention is needed review Data and Metadata review v1.5.1 metadata created with version 1.5.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants