Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEO Viewer: Some terms are missing definitions #1814

Open
1 task
amanda-wein opened this issue Sep 4, 2024 · 3 comments
Open
1 task

OEO Viewer: Some terms are missing definitions #1814

amanda-wein opened this issue Sep 4, 2024 · 3 comments
Labels
bug NFDI Issues related to NFDI

Comments

@amanda-wein
Copy link

Description of the issue

In the OEO Viewer, some terms only have a name and an ID listed and are missing a definition, even though a definition does exist in the OEO itself. I haven't checked all terms, but some of the ones with this problem are

  • site (BFO_0000029)
  • prefix (UO_0000046)
  • one-dimensional continuant fiat boundary (BFO_0000142)
  • two-dimensional continuant fiat boundary (BFO_0000146)
  • three-dimensional spatial region (BFO_0000028)
  • realizable entity (BFO_0000017)
  • quality (BFO_0000019)

The problem appears to be with terms that are imported from other ontologies, but not all imported terms are affected. For example, the terms "spatial region" and "specifically dependent continuant" from BFO, and the terms "unit" and "energy unit" from UO, display their definitions in the viewer without any issues.

Ideas of solution

Update the OEO Viewer to correctly find these definitions in the OEO and display them.

Context and Environment

Using the OEO Viewer in Firefox version 115.14.0esr (64-bit)

Workflow checklist

@amanda-wein amanda-wein added the bug label Sep 4, 2024
@amanda-wein
Copy link
Author

@jh-RLI @christian-rli It doesn't look like I have permissions to apply more labels to this. Could one of you add the NFDI label like we talked about in our meeting yesterday, or give my account permission to make that change? Thanks!

@stap-m
Copy link
Contributor

stap-m commented Sep 4, 2024

@amanda-wein I add you the the organization, then you should be able to add labels and all the other stuff...

@amanda-wein
Copy link
Author

@stap-m I accepted the invitation but I still don't see any option to edit labels on an issue, unfortunately.

Looks like I need to have triage access to the repository to do this: https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels

@a-steinert a-steinert added the NFDI Issues related to NFDI label Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NFDI Issues related to NFDI
Projects
None yet
Development

No branches or pull requests

3 participants