Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEP Data Upload Wizard and API: Clarify table & column name syntax #1826

Open
1 task
amanda-wein opened this issue Sep 9, 2024 · 0 comments
Open
1 task
Labels
enhancement NFDI Issues related to NFDI

Comments

@amanda-wein
Copy link

Description of the issue

When creating a new table in the upload wizard, the only guidance given for table and column names is that lower case letters, numbers, and underscores are the only valid characters, and that the character limit is 50. Based on this, a column name that is simply a single number, or a column name that starts with a number and is followed by letters or underscores, should be accepted. However, if one tries to create a table with this column name, the column name field is highlighted to indicate an error and the error message "Invalid definitions" is displayed after clicking the Create Table button. However, the tooltip guidance indicates that this column name is valid.

colname-1

This is a restriction of PostgreSQL, that column names can't start with numbers. That isn't mentioned in the data upload wizard, or in any documentation for the wizard or the API. If one does try to use an invalid column name, the error messages (in both the wizard and the API) indicate that something has gone wrong, but don't give the user any information as to what the problem is or how to fix it.

Ideas of solution

The following adjustments would make the data upload process clearer:

  • In the data upload wizard, edit the tooltip guidance to indicate that column names cannot start with a number.
  • In the data upload wizard documentation, add details about the correct formatting of table and column names.
  • In the API documentation, add details about the correct formatting of table and column names.
  • In the data upload wizard, make the error messages more detailed to indicate to the user exactly where & what the error is if a table can't be created successfully.
  • In the API, make the error messages more detailed to indicate to the user exactly where & what the error is if a table can't be created successfully.

Workflow checklist

@a-steinert a-steinert added the NFDI Issues related to NFDI label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement NFDI Issues related to NFDI
Projects
None yet
Development

No branches or pull requests

2 participants