Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR template should be in imperative style #1586

Closed
1 task
l-emele opened this issue Jun 15, 2023 · 2 comments · Fixed by #1769
Closed
1 task

PR template should be in imperative style #1586

l-emele opened this issue Jun 15, 2023 · 2 comments · Fixed by #1769
Assignees
Labels
To do Issues that haven't got discussed yet

Comments

@l-emele
Copy link
Contributor

l-emele commented Jun 15, 2023

Description of the issue

For the commits, we decided to use imperative commit messages.

With the PR you intend to change the dev branch (by merging the commits from your feature branch), that is conceptually also same, it is also a targeted action that you intend to do.

Therefore, I think we should also use the imperative convention for the pull requests.

Ideas of solution

Change section headings in the PR template:

  • Added -> add
  • Update -> update
  • Removed -> remove

Workflow checklist

  • I am aware of the workflow for this repository
@l-emele l-emele added the To do Issues that haven't got discussed yet label Jun 15, 2023
@l-emele l-emele added this to the oeo-release-2.1.0 milestone Nov 21, 2023
@l-emele
Copy link
Contributor Author

l-emele commented Nov 21, 2023

I opened this issue almost half a year ago. Nobody reacted to my proposal. Seems nobody except me has an opinion and especially nobody objects my proposal.

If in the next days nobody reacts I will implement as proposed.

@l-emele l-emele self-assigned this Nov 21, 2023
@l-emele
Copy link
Contributor Author

l-emele commented Nov 28, 2023

I'll implement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To do Issues that haven't got discussed yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants