Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of has memo item axioms #1730

Closed
5 tasks
l-emele opened this issue Oct 23, 2023 · 0 comments · Fixed by #1733
Closed
5 tasks

Duplication of has memo item axioms #1730

l-emele opened this issue Oct 23, 2023 · 0 comments · Fixed by #1733
Assignees
Labels
[B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet

Comments

@l-emele
Copy link
Contributor

l-emele commented Oct 23, 2023

Description of the issue

Some change of our restructuring efforts have lead that some sector individuals have duplicated has memo item axioms, one with a term tracker item and one without term tracker item.

grafik

This is in the dev branch, so it is not caused by the PR

The object property has memo item was introduced in PR #967, however the term tracker items wrongly reference PR #965.

Ideas of solution

After merging of PR #1724, delete the duplicated has memo item axioms, i.e. those which do not have term tracker items.
Also fix PR numbers in term tracker items.

The changes required are not complicated and we thus should include this in the 2.0.0 release (or latest in 2.0.1 if we do a hotfix for other reasons).

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@l-emele l-emele added [B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet labels Oct 23, 2023
@l-emele l-emele added this to the oeo-release-2.0.0-thematical milestone Oct 23, 2023
@l-emele l-emele mentioned this issue Oct 23, 2023
5 tasks
@l-emele l-emele self-assigned this Oct 23, 2023
l-emele added a commit that referenced this issue Oct 23, 2023
l-emele added a commit that referenced this issue Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[B] restructure Restructuring existing parts of the ontology To do Issues that haven't got discussed yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant