Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose Megawatt-hour and other units - oeox paper quick fix #1830

Closed
nelekoehler opened this issue Apr 16, 2024 · 9 comments · Fixed by #1845
Closed

Compose Megawatt-hour and other units - oeox paper quick fix #1830

nelekoehler opened this issue Apr 16, 2024 · 9 comments · Fixed by #1845
Assignees
Labels
[C] definition update Update an ontology definition

Comments

@nelekoehler
Copy link
Contributor

nelekoehler commented Apr 16, 2024

Description of the issue

We already have implemented Megawatt-hour as an own energy-unit, but But because we now have oeo-extended and can compose new units from basic units, we should also add composed units such as megawatt-hour as such through composition. In particular, we want to use megawatt-hour as an example for a paper on oeox, which is why it should be implemented as soon as possible.
We should collect other units that we also want to compose again.
Here is a first list of the energy units:

  • Megawatt-hour
  • Gigawatt-hour
  • Petawatt-hour
  • Terawatt-hour

Ideas of solution

The composition for Megawatt-hour could look like this:

Megawatt-hour
EquivalentTo unit
and 'has linear unit numerator' some (watt-hour
and 'has prefix' some mega)

@nelekoehler nelekoehler added [C] definition update Update an ontology definition To do Issues that haven't got discussed yet labels Apr 16, 2024
@stap-m
Copy link
Contributor

stap-m commented Apr 16, 2024

We need the prefix relation for that, see #1402

@stap-m stap-m added this to the oeo-release-2.3.0 milestone Apr 18, 2024
@l-emele
Copy link
Contributor

l-emele commented Apr 19, 2024

Here is a first list of the energy units:

* Megawatt-hour

* Gigawatt-hour

* Petawatt-hour

Terawatt-hour is missing in that list.

@chrwm
Copy link
Member

chrwm commented Apr 22, 2024

Just to clarify - the units below should be implemented in oeo-extended.omn, isn't it?

If so, should the issue be moved to oeo-extended?

Units:

  • Megawatt-hour
  • Gigawatt-hour
  • Petawatt-hour
  • Terawatt-hour

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Apr 22, 2024
@stap-m
Copy link
Contributor

stap-m commented Apr 22, 2024

Just to clarify - the units below should be implemented in oeo-extended.omn, isn't it?

No, they are essential for the domain and can live in OEO. However, they will be used for other composed units, such as MWh/m2a in OEOX.

@l-emele
Copy link
Contributor

l-emele commented Apr 22, 2024

gigawatt-hour, megawatt-hour, petawatt-hour and terawatt-hour should be made subclasses of watthour-based unit (as already kilowatt-hour and watt-hour are)

@NormanZielke
Copy link
Contributor

NormanZielke commented Apr 22, 2024

I would implement

  • megawatt-hour (already existing as subclass of energy unit: will be moved -> subclass of watt-hour based unit)

Definition:
definition "An energy unit which is equal to 1,000,000 watt-hours."
hasExactSynonym: "MWh"

EquivalentTo unit
and has linear unit numerator some (watt-hour
and has prefix some mega)

  • gigawatt-hour (already existing as subclass of energy unit: will be moved -> subclass of watt-hour based unit)

Definition:
definition "An energy unit which is equal to 1,000,000,000 watt-hours."
hasExactSynonym: "GWh"
EquivalentTo unit
and has linear unit numerator some (watt-hour
and has prefix some giga)

  • terawatt-hour (already existing as subclass of energy unit: will be moved -> subclass of watt-hour based unit)

Definition:
definition "An energy unit which is equal to 1,000,000,000,000 watt-hours."
hasExactSynonym: "TWh"
EquivalentTo unit
and has linear unit numerator some (watt-hour
and has prefix some tera)

  • petawatt-hour (already existing as subclass of energy unit: will be moved -> subclass of watt-hour based unit)

Definition:
definition "An energy unit which is equal to 1,000,000,000,000,000 watt-hours."
hasExactSynonym: "PWh"
EquivalentTo unit
and has linear unit numerator some (watt-hour
and has prefix some peta)

as subclasses of watthour-based unit

If this is fine for you, I would start to implement on wednesday together with Nele

@stap-m
Copy link
Contributor

stap-m commented Apr 23, 2024

For example, terawatt-hour is currently defined as An energy unit which is equal to 10^12 watt-hours..
I'd prefer expressions like 10^12 over 1,000,000,000,000.

@l-emele
Copy link
Contributor

l-emele commented Apr 23, 2024

For example, terawatt-hour is currently defined as An energy unit which is equal to 10^12 watt-hours..
I'd prefer expressions like 10^12 over 1,000,000,000,000.

I agree.

@l-emele
Copy link
Contributor

l-emele commented Apr 23, 2024

Also we should make it proper Aristotelian definitions, e.g. instead of An energy unit which is equal to 10^12 watt-hours. we should define: A terawatt-hour is a watt-hour based unit which is equal to 10^12 watt-hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] definition update Update an ontology definition
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants