Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 3 object aggregates subclasses of (supply) system #1833 #1947

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Make 3 object aggregates subclasses of (supply) system #1833 #1947

wants to merge 8 commits into from

Conversation

madbkr
Copy link
Contributor

@madbkr madbkr commented Oct 14, 2024 •
edited
Loading

Summary of the discussion

See #1833.
As agreed in the discussion supply grid, transport network and critical infrastructure should be supply systems instead of object aggregates. I changed the definitions accordingly.
Please let me know if the equivalence for critical infrastructure should change (as also asked in #1833)

Type of change (CHANGELOG.md)

Update

  • move supply grid, transport network and critical infrastructure to subclass of supply system

Workflow checklist

Automation

Closes #1833

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guide
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@github-actions github-actions bot added the oeo-physical changes the oeo-physical module label Oct 14, 2024
@madbkr madbkr requested a review from stap-m October 14, 2024 12:44
@madbkr madbkr self-assigned this Oct 14, 2024
@madbkr madbkr marked this pull request as ready for review October 17, 2024 09:27
stap-m
stap-m reviewed Oct 17, 2024
View reviewed changes
Copy link
Contributor

@stap-m stap-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. Just some minor things.
I am wondering, why there are so many changes that are no actual changes. This makes the review confusing. I thought we had fixed that. Did you pull from the latest dev version?

CHANGELOG.md Outdated Show resolved Hide resolved
src/ontology/edits/oeo-physical.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-physical.omn Outdated Show resolved Hide resolved
src/ontology/edits/oeo-physical.omn Outdated Show resolved Hide resolved
@madbkr
Copy link
Contributor Author

madbkr commented Oct 17, 2024 •
edited
Loading

Looks good, thanks. Just some minor things. I am wondering, why there are so many changes that are no actual changes. This makes the review confusing. I thought we had fixed that. Did you pull from the latest dev version?

I branched this while we still had the bug with the doubles lables. I think that's where this problem came from. Maybe I should have merged dev into it again and that would have avoided the problem.

I applied your changes. I feel like I always have trouble knowing how brief to be in changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stap-m stap-m stap-m left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@madbkr madbkr

Labels
oeo-physical changes the oeo-physical module
Projects
Issues
Status: Review in progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

make supply grid and transportation networt subclasses of (supply) system
2 participants
@madbkr @stap-m