Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build oeo-closure only during release process #1934

Open
1 task
l-emele opened this issue Sep 24, 2024 · 1 comment
Open
1 task

Build oeo-closure only during release process #1934

l-emele opened this issue Sep 24, 2024 · 1 comment
Assignees
Labels
To do Issues that haven't got discussed yet

Comments

@l-emele
Copy link
Contributor

l-emele commented Sep 24, 2024

Description of the issue

Currently, oeo-closure is built after every commit. This takes significant amount of time.
Maybe it is enough, if oeo-closure is only built for pull requests to the master branch or after a release.

Ideas of solution

If you already have ideas for the solution describe them here

Workflow checklist

  • I am aware of the workflow for this repository
@l-emele l-emele added the To do Issues that haven't got discussed yet label Sep 24, 2024
@l-emele l-emele added this to the oeo-release-2.6.0 milestone Sep 24, 2024
@ColinHDev
Copy link
Contributor

ColinHDev commented Oct 5, 2024

So you are referring to these two steps?
image

Whether it is enough to only run the build and test steps in these cases, is probably decided by someone else - @stap-m?
But, it should be possible to integrate these conditions into the workflow.

[...] oeo-closure is only built for pull requests to the master branch or after a release.

So, both steps should no longer run e.g. on the default branch, but only

  • on branches associated with open pull requests targeting the default branch or
  • on the default branch if a new tag (e.g. v2.5.0) has been published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
To do Issues that haven't got discussed yet
Projects
None yet
Development

No branches or pull requests

2 participants