Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParseVar doesn't handle quoted strings properly #2552

Closed
deslaughter opened this issue Dec 10, 2024 · 3 comments
Closed

ParseVar doesn't handle quoted strings properly #2552

deslaughter opened this issue Dec 10, 2024 · 3 comments
Assignees
Milestone

Comments

@deslaughter
Copy link
Collaborator

Bug description

When ParseVar is used to read quoted strings, such as a file path, it will split the path if it contains a space even though it is within the quotes. The previous guidance has been that paths cannot contain spaces, but this seems like a simple problem to fix.

To Reproduce

Steps to reproduce the behavior:

  1. Specify a path containing a space inside a quoted string in the Aerodyn input file for OLAFInputFIleName.
  2. OpenFAST will report that it can't find the file because it splits the path at the space.

Expected behavior

OpenFAST should use the full path between the double quotes.

OpenFAST Version

**************************************************************************************************
 OpenFAST

 Copyright (C)  National Renewable Energy Laboratory
 Copyright (C)  Envision Energy USA LTD

 This program is licensed under Apache License Version 2.0 and comes with ABSOLUTELY NO WARRANTY.
 See the "LICENSE" file distributed with this software for details.
 **************************************************************************************************

 OpenFAST-v3.5.3
@deslaughter deslaughter added this to the v3.5.5 milestone Dec 10, 2024
@deslaughter deslaughter self-assigned this Dec 10, 2024
@andrew-platt
Copy link
Collaborator

We might need to add a new routine specifically for file name handling.

@andrew-platt
Copy link
Collaborator

We introduced the new file parsing to the primary AeroDyn input file in version 2.6.0, May 2021. I'm a little surprised that this hasn't been an issue for anyone until now.

This was added for some the other modules later, such as InflowWind and HydroDyn.

@andrew-platt
Copy link
Collaborator

Fixed with #2558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants