Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update openmrs to use the new http module #474

Closed
taylordowns2000 opened this issue Feb 14, 2024 · 0 comments · Fixed by #475
Closed

Update openmrs to use the new http module #474

taylordowns2000 opened this issue Feb 14, 2024 · 0 comments · Fixed by #475
Assignees

Comments

@taylordowns2000
Copy link
Member

taylordowns2000 commented Feb 14, 2024

Based on the patterns specified in #283, #320 , and #315 , migrate language-openmrs off of request and superagent.

The new version should:

  1. Use the standard format for http requests defined in https://github.com/OpenFn/adaptors/blob/main/packages/template/src/Utils.js
  2. Have no reference to axios, superagent or the old npm request module. (Should be handled in the point above.)
  3. Remove the custom logger - this is a pattern we want to avoid/remove wherever we see it
  4. Be tested against the OpenMRS demo

@mtuchi will be able to provide additional guidance here

@taylordowns2000 taylordowns2000 moved this to Backlog in v2 Feb 14, 2024
@mtuchi mtuchi changed the title Move openmrs to the new http module Update openmrs to use the new http module Feb 14, 2024
@hunterachieng hunterachieng moved this from Backlog to Ready in v2 Feb 14, 2024
@taylordowns2000 taylordowns2000 moved this from Ready to Backlog in v2 Feb 15, 2024
@taylordowns2000 taylordowns2000 moved this from Backlog to Ready in v2 Feb 15, 2024
@hunterachieng hunterachieng moved this from Ready to In progress in v2 Feb 16, 2024
@hunterachieng hunterachieng moved this from In progress to In review in v2 Feb 22, 2024
@taylordowns2000 taylordowns2000 moved this from In review to In progress in v2 Feb 23, 2024
@hunterachieng hunterachieng moved this from In progress to In review in v2 Feb 26, 2024
@taylordowns2000 taylordowns2000 moved this from In review to In progress in v2 Feb 27, 2024
@hunterachieng hunterachieng moved this from In progress to In review in v2 Feb 28, 2024
@taylordowns2000 taylordowns2000 moved this from In review to In progress in v2 Feb 29, 2024
@hunterachieng hunterachieng moved this from In progress to In review in v2 Mar 1, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in v2 Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants