Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiler: detect suspicious JSONpath strings #803

Open
josephjclark opened this issue Oct 28, 2024 · 0 comments
Open

compiler: detect suspicious JSONpath strings #803

josephjclark opened this issue Oct 28, 2024 · 0 comments

Comments

@josephjclark
Copy link
Collaborator

Follow up to #781

JSON path strings in old adaptor versions to provide an attack vector to run arbritary code. I do not know if this allows breaking out of the sandbox.

https://security.snyk.io/vuln/SNYK-JS-JSONPATHPLUS-7945884

The compiler could detect suspicious json path strings and throw an error, refusing the execute the job.

If we detect a json path string like $.a.b.c with anything weird in it, like parenthesis, the compiler could throw.

Workflows which do use jsonpath strings should really only be using super simple expressions, and I'd be reasonably happy to throw if anything looks amiss in those strings. I think the pattern is fairly strong.

@github-project-automation github-project-automation bot moved this to New Issues in v2 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

No branches or pull requests

1 participant