Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: Warn when an operation is called not at the top level #629

Open
josephjclark opened this issue Mar 18, 2024 · 2 comments
Open

Comments

@josephjclark
Copy link
Collaborator

This is an antipattern we see all the time, where an operation is nested and must be called like post(...)(state):

get('/some-data', (state) => {
   post('some-data, state.data)(state)
})

The compiler should be able to detect nested operation calls like this and log some kind of warning to users. It may even be able to suggest a refactor snippet to show what we mean.

@github-project-automation github-project-automation bot moved this to New Issues in v2 Mar 18, 2024
@josephjclark josephjclark removed this from v2 Mar 18, 2024
@josephjclark
Copy link
Collaborator Author

Difficulty right now is that Lightning won't see it. Need to fix #392 first

@github-project-automation github-project-automation bot moved this to New Issues in v2 Jul 29, 2024
@doc-han doc-han self-assigned this Nov 27, 2024
@doc-han
Copy link
Collaborator

doc-han commented Dec 15, 2024

Difficulty right now is that Lightning won't see it. Need to fix #392 first

Yup, but soon, our vsc integration will need that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

No branches or pull requests

2 participants