Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: support disabling all logs #655

Open
josephjclark opened this issue Apr 10, 2024 · 2 comments
Open

worker: support disabling all logs #655

josephjclark opened this issue Apr 10, 2024 · 2 comments

Comments

@josephjclark
Copy link
Collaborator

We need to support a mode where all logging is disabled - logs don#t go to stdout and don't go to lightning.

Right now have a bunch of logging policies, I think they're called sanitisation policies? We proably just need to ensure there's one of those for "silent"

I don't think this is supported today

@josephjclark josephjclark added this to v2 Apr 10, 2024
@github-project-automation github-project-automation bot moved this to New Issues in v2 Apr 10, 2024
@josephjclark josephjclark moved this from New Issues to Backlog in v2 Apr 10, 2024
SatyamMattoo added a commit to SatyamMattoo/kit that referenced this issue May 11, 2024
@SatyamMattoo SatyamMattoo mentioned this issue May 11, 2024
3 tasks
@SatyamMattoo
Copy link
Contributor

Hello @josephjclark I have added the sanitization policy as proposed and it seems to be serving the purpose. I am a bit unsure about the approach, as I had another approach in mind where we could add a log function (warn, debug, success etc.) which might also serve the same purpose. I am unsure about these but hopefully you will guide me through.
Best Regards

@josephjclark
Copy link
Collaborator Author

I've been thinking about this after @SatyamMattoo's PR. The original issue is slightly confused and I'll have to address it in the week.

In the meantime here are better notes:

The logger already supports a log=none mode which is used by the CLI.

Right now the worker always uses debug, so that all logs are returned and can be filtered by the user.

What we need is for the worker to support a logLevel option. This should be defaulted on startup and override by run options.

Later, Lightning can choose to set the log level to none whenever it wishes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants