-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
worker: support disabling all logs #655
Comments
Hello @josephjclark I have added the sanitization policy as proposed and it seems to be serving the purpose. I am a bit unsure about the approach, as I had another approach in mind where we could add a log function (warn, debug, success etc.) which might also serve the same purpose. I am unsure about these but hopefully you will guide me through. |
I've been thinking about this after @SatyamMattoo's PR. The original issue is slightly confused and I'll have to address it in the week. In the meantime here are better notes: The logger already supports a Right now the worker always uses What we need is for the worker to support a Later, Lightning can choose to set the log level to |
We need to support a mode where all logging is disabled - logs don#t go to stdout and don't go to lightning.
Right now have a bunch of logging policies, I think they're called sanitisation policies? We proably just need to ensure there's one of those for "silent"
I don't think this is supported today
The text was updated successfully, but these errors were encountered: