Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime: support multiple inputs #698

Closed
josephjclark opened this issue May 24, 2024 · 0 comments · Fixed by #704
Closed

Runtime: support multiple inputs #698

josephjclark opened this issue May 24, 2024 · 0 comments · Fixed by #704
Assignees

Comments

@josephjclark
Copy link
Collaborator

josephjclark commented May 24, 2024

The runtime needs to be able to support multiple inputs to a node.

This doesn't need to do anything particularly clever - if multiple edges lead to a node, that node gets called multiple times. We just need to ensure the correct input state is used - but I think we've already solved that.

We need to remove the validation that enforces that the workflow must be a tree.

We currently have loop detection - I suggest we keep that in place.

I am hoping that because this isn't technically hard, and we've got solid and simple execution rules, that this won't be more than day's work.

@github-project-automation github-project-automation bot moved this to New Issues in v2 May 24, 2024
@josephjclark josephjclark moved this from New Issues to Ready in v2 May 24, 2024
@josephjclark josephjclark moved this from Ready to In progress in v2 May 28, 2024
@josephjclark josephjclark self-assigned this May 28, 2024
@josephjclark josephjclark moved this from In progress to In review in v2 May 29, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in v2 Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant