Logger: Removed configuration from final state

[josephjclark]

I hate this line:

Removed configuration from final state

It's a reasonably important line. It runs at the end of every step.

But when there's an error, it tends to appear before the error. Or it's the last log line we receive.

And it looks like it's the cause of a fail, rather than the effect of a step being completed.

I'm not really sure what to do about this. Logging to debug and adding a debug filter would help.

[doc-han]

1. Unable to reproduce a situation where that line is logged after an error.
2. I get beautiful logs on CLI that helps in knowing which part of the logs shows the error.

3. Maybe it's just a UI thing where lightening logs needs to also be colorful?

[josephjclark]

I think a bit of context would go a long way here.

Maybe if the logs looked more like this (I'm just sketching, and on a mobile device too)

(Debug) Step complete with status: complete
(Debug) Cleaning up state. Removing keys: configuration 

In such a long, the key removal always comes after some kind of orderly job closure, so it makes a bit more sense about what is happening

[josephjclark]

Or I suppose just having the key removal line AFTER the job failed line would go a long way

[doc-han]

Ohkay, that makes sense.