Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Initiate Github Sync" take the latest snapshots at the time of initiation #1827

Closed
Tracked by #1680
taylordowns2000 opened this issue Feb 28, 2024 · 3 comments · Fixed by #2273
Closed
Tracked by #1680
Assignees

Comments

@taylordowns2000
Copy link
Member

taylordowns2000 commented Feb 28, 2024

When you "initiate a sync" to Github via the Project Settings screen, it should contain send the latest workflow snapshot for all workflows in the project and send those UUIDs to Github.

This will avoid "drift" between when the sync is initiated and when the openfn pull command actually grabs yaml from openfn.org

@taylordowns2000 taylordowns2000 moved this to New Issues in v2 Feb 28, 2024
@christad92 christad92 moved this from New Issues to Backlog in v2 Feb 28, 2024
@christad92
Copy link

@taylordowns2000 I would like to propose that we have the Save & Sync button on the canvas (probably beside the save button) rather than on the inspector page because :

  • The inspector primary controls the current step; and
  • The existing buttons on the inspector (Create New Work Order and Save) function within the scope of that step.

@taylordowns2000 taylordowns2000 moved this from Backlog to New Issues in v2 Feb 29, 2024
@taylordowns2000 taylordowns2000 moved this from New Issues to Icebox in v2 Feb 29, 2024
@taylordowns2000 taylordowns2000 moved this from Icebox to Backlog in v2 Feb 29, 2024
@taylordowns2000 taylordowns2000 moved this from Backlog to Icebox in v2 Mar 16, 2024
@christad92 christad92 moved this from Icebox to Backlog in v2 Mar 17, 2024
@christad92 christad92 moved this from Backlog to Icebox in v2 Mar 17, 2024
@christad92 christad92 moved this from Icebox to Backlog in v2 Mar 29, 2024
@christad92 christad92 moved this from Backlog to Ready in v2 May 10, 2024
@christad92 christad92 moved this from Ready to Backlog in v2 Jun 6, 2024
@christad92 christad92 moved this from Backlog to Ready in v2 Jul 4, 2024
@christad92 christad92 changed the title Make "Initiate Github Sync" take the latest snapshots Make "Initiate Github Sync" take the latest snapshots at the time of request Jul 4, 2024
@christad92 christad92 changed the title Make "Initiate Github Sync" take the latest snapshots at the time of request Make "Initiate Github Sync" take the latest snapshots at the time of initiation Jul 4, 2024
@midigofrank midigofrank self-assigned this Jul 8, 2024
@midigofrank midigofrank moved this from Ready to In progress in v2 Jul 8, 2024
@midigofrank midigofrank moved this from In progress to Blocked in v2 Jul 17, 2024
@midigofrank
Copy link
Collaborator

Blocked, waiting for OpenFn/kit#729

@midigofrank midigofrank moved this from Blocked to In progress in v2 Jul 17, 2024
@christad92
Copy link

#729 has been merged.. Can you raise a PR for this, if it's ready?

Thanks

@christad92 christad92 moved this from In progress to Backlog in v2 Jul 18, 2024
@midigofrank midigofrank moved this from Backlog to In progress in v2 Jul 29, 2024
@midigofrank midigofrank moved this from In progress to In review in v2 Jul 29, 2024
@github-project-automation github-project-automation bot moved this from In review to Done in v2 Jul 30, 2024
@christad92 christad92 mentioned this issue Aug 4, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants