Add Protocol Errors
#441
Add Protocol Errors
#441
Conversation
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 98.51% 98.52%
=======================================
Files 38 39 +1
Lines 2158 2166 +8
=======================================
+ Hits 2126 2134 +8
Misses 32 32 ☔ View full report in Codecov by Sentry. |
gufe/protocols/errors.py
Outdated
|
|
||
|
|
||
| # Protocol Results Errors | ||
| class MissingProtocolUnitError(Exception): |
There was a problem hiding this comment.
Do you mean a missing UnitResult?
gufe/protocols/errors.py
Outdated
|
|
||
|
|
||
| # Protocol Errors | ||
| class ProtocolValidationError(Exception): |
There was a problem hiding this comment.
Should we be subclassing out of a "BaseGufeException" type? I'm thinking it might be useful to have a catch-all that isn't a Exception in some cases.
For example - it might be good for execute_DAG to capture all of these and prevent trying to restart the DAG (i.e. if these are known deterministic failures, then we should assume they will happen over and over again).
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
@ijpulidos since this PR addresses #385, would you be willing to offer your feedback on this one? |
|
@hannahbaumann since you're working in detail on protocols, would you be willing to offer feedback on our choices here? |
|
pre-commit.ci autofix |
1 similar comment
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Fixes #385 by adding specific protocol execution and results errors.
Tips
Since this will create a commit, it is best to make this comment when you are finished with your work.
Checklist
newsentryDevelopers certificate of origin