Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uproot3 -> uproot #52

Open
djboersma opened this issue Jan 19, 2021 · 4 comments
Open

uproot3 -> uproot #52

djboersma opened this issue Jan 19, 2021 · 4 comments

Comments

@djboersma
Copy link
Contributor

I'm getting noisy messages that "uproot3" is now deprecated and we should use "uproot" instead, because python3 is now the default. A similarly noisy warning for "awkward0" which should now be "awkward".

This should be fairly easy to fix but I have zero time this week so I'll just leave this issue here.

@tbaudier
Copy link
Contributor

tbaudier commented Jan 22, 2021

@djboersma OpenGATE/Gate#402 (comment)

I think that this just illustrates why we should try to get rid of ROOT in Gate. At the moment we basically only use ROOT for storing output: phase spaces (TTree), images and dose distributions (TH2, TH3). Maybe we should enable the conversion utilities for phase spaces and images in GateTools to also write ROOT output, so that users who for some reason really need their data in ROOT format can use that to do that to still get their work done.

(wrong thread I suppose)

@djboersma
Copy link
Contributor Author

@djboersma OpenGATE/Gate#402 (comment)

I think that this just illustrates why we should try to get rid of ROOT in Gate. At the moment we basically only use ROOT for storing output: phase spaces (TTree), images and dose distributions (TH2, TH3). Maybe we should enable the conversion utilities for phase spaces and images in GateTools to also write ROOT output, so that users who for some reason really need their data in ROOT format can use that to do that to still get their work done.

(wrong thread I suppose)

Well I guess it belongs in both. My comment in Gate issue 402 is about the pain of supporting ROOT in Gate, we try to use it as if it is a few of ROOT's features but the build system flags are for using the entire framework and GUI. But there are users who really want to do their analysis with ROOT. To keep them happy and make us happy, I was suggesting to remove ROOT from Gate and allow conversion to ROOT format by the tools.

This particular "uproot3" issue I raised just to get rid of the noisy version warnings that I was getting from the uproot(3) module on my systems. Just a maintenance issue, not a discussion about the functionality of GateTools really. I guess I should create a separate issue about it. Maybe better to postpone this discussion until after the upcoming Gate release.

@tbaudier
Copy link
Contributor

Sorry I did not understand the issue. The issue 402 was about the compilation of Gate on Github actions (and more specially brew), not related to ROTT, I thought you talked about that issue in the GateTools.
For ROOT in Gate, maybe we can think to put it in the CMake options.

For uproot3, since December 2020, they changed uproot3 to uproot4. Previously I decided to keep uproot3 because uproot4 is not able to write root files for the moment (and some others features). But the warning message is so annoying, I changed to uproot4 (called uproot now) in setup.py and all tools. Except for writing, I keep uproot3 and the tool works only if the library is available.

@tbaudier
Copy link
Contributor

tbaudier commented Feb 3, 2021

#57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants