Additional API updates #103
Open
+159
−161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annehaley
changed the title
jjnesbitt
reviewed
Feb 24, 2025
uvdat/core/tasks/networks.py
Outdated
| @@ -25,6 +25,7 @@ def create_network(vector_data, network_options): | |||
| dataset = vector_data.dataset | |||
| Network.objects.filter(vector_data__dataset=dataset).delete() | |||
| network = Network.objects.create( | |||
| name=dataset.name + ' Network', | |||
There was a problem hiding this comment.
Are we currently constraining Networks to be one-to-one with datasets?
There was a problem hiding this comment.
No, do you think that we should add numbering to this name string to account for multi-network datasets?
There was a problem hiding this comment.
Added numbering to avoid name conflicts in 93f7e45
jjnesbitt
reviewed
Feb 24, 2025
uvdat/core/rest/networks.py
Outdated
Comment on lines
33
to
34
| gcc = network.get_gcc(excluded_nodes=exclude_nodes) | ||
| return Response(gcc, status=200) |
There was a problem hiding this comment.
It's probably best to use a serializer here, but I understand this is just relocated code. Not a huge deal imo.
There was a problem hiding this comment.
Created a custom serializer to validate gcc results in 98e1d2b
zachmullen
reviewed
Feb 27, 2025
|
|
||
| def get_dataset_name(self, obj): | ||
| return obj.dataset.name | ||
| list_display = ['id', 'category'] |
There was a problem hiding this comment.
Why remove the dataset name? Is it not something administrators would want to see in this view?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of continuing UI updates on #102, I found some more server-side changes that are needed to use the new Network model in our API. This includes an update to the new
TokenAuthclass and a new set of viewpoints for Networks. The client will now leverage these endpoints for Network-related logic (rather than going through Dataset endpoints, since the relationship between a Network and a Dataset is no longer one-to-one).