Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For some bitstream, get_cabac_bypass() will read 2 extra bytes #50

Open
hxz1986 opened this issue Oct 18, 2016 · 6 comments
Open

For some bitstream, get_cabac_bypass() will read 2 extra bytes #50

hxz1986 opened this issue Oct 18, 2016 · 6 comments

Comments

@hxz1986
Copy link

hxz1986 commented Oct 18, 2016

And it will crash for memory out of bound error. Is it a known issue?

Thanks!!

@pcabarat
Copy link
Collaborator

pcabarat commented Oct 18, 2016

Hi.
We didn't know about this issue. Can you provide us with a bitstream so we can reproduce the issue?
Which branch did you use?

Pierre-Loup

@hxz1986
Copy link
Author

hxz1986 commented Oct 19, 2016

Hi Pierre-Loup,

Thanks for your quick response. I attached the bitstream. It seems the
cabac decoder of openhevc will read 2 bytes ahead. In some cases, it will
read memory out of bound.

Xiaozheng

BR,
Xiaozheng Huang

2016-10-18 18:59 GMT+08:00 Pierre-Loup Cabarat [email protected]:

Hi.
We didn't know about this issue. Can you provide us with a bitstream so we
can reproduce the issue?
What branch did you use?

Pierre-Loup


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#50 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV2DI1fyvaCRb8-B5dXEqGx8zZ37GqTTks5q1KaSgaJpZM4KZcbu
.

@hxz1986
Copy link
Author

hxz1986 commented Oct 19, 2016

The latest openhevc can still reproduce this issue.

BR,
Xiaozheng Huang

2016-10-19 10:26 GMT+08:00 Huang Xiaozheng [email protected]:

Hi Pierre-Loup,

Thanks for your quick response. I attached the bitstream. It seems the
cabac decoder of openhevc will read 2 bytes ahead. In some cases, it will
read memory out of bound.

Xiaozheng

BR,
Xiaozheng Huang

2016-10-18 18:59 GMT+08:00 Pierre-Loup Cabarat [email protected]:

Hi.
We didn't know about this issue. Can you provide us with a bitstream so
we can reproduce the issue?
What branch did you use?

Pierre-Loup


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#50 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AV2DI1fyvaCRb8-B5dXEqGx8zZ37GqTTks5q1KaSgaJpZM4KZcbu
.

@hxz1986
Copy link
Author

hxz1986 commented Oct 19, 2016

It seems email attachment does not work. I attached a problematic bitstream here. Please remove ".txt".
2bytes.265.txt

@hxz1986
Copy link
Author

hxz1986 commented Oct 19, 2016

To repro this issue, you must allocate the exact number of bytes as the the bitstream size and use app verifier to help repro this crash.

@pcabarat
Copy link
Collaborator

It plays well on Rext and HEVC_extensions on my computer. I'll need more explanations:
What do you mean by allocate the exact number of bytes as the bitstream?
How do you use the decoder?
When does it crash? (end of decoding)
Does it works on other streams ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants