Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] .remarkrc.mjs does not spark joy (e.g., remark-preset-* deps) #501

Closed
DerekNonGeneric opened this issue Aug 16, 2023 · 8 comments
Closed
Assignees
Labels
backlog Issues and PRs, held in reserve, for future handling, processing, or repair bug Something isn't working javascript PRs that update JavaScript code linting Issues and PRs that deal with linting markdown An issue or PR related to Markdown tools Issues and PRs related to the tools directory

Comments

@DerekNonGeneric
Copy link
Member

image

This has been an ongoing issue, and we (@OpenINF/wg-a-team) have started working on this in other channels and repos (e.g., our yet-to-be launched @OpenINF/standards repo).

I want to get this taken care of here and now while taking those learnings back to that project.

@DerekNonGeneric DerekNonGeneric added bug Something isn't working tools Issues and PRs related to the tools directory linting Issues and PRs that deal with linting javascript PRs that update JavaScript code markdown An issue or PR related to Markdown labels Aug 16, 2023
@DerekNonGeneric
Copy link
Member Author

Presets of remark-lint rules can be folded into a single @OpenINF dependency, but prior to doing that, let's see about whether we have duplication btwx all of our currently-depended-on remark-preset-* deps).

@DerekNonGeneric
Copy link
Member Author

.github/.remarkrc.mjs

Lines 82 to 83 in bdf59bd

[await import('remark-lint-blockquote-indentation'), 2],
[

remark-lint-blockquote-indentation

… is contained in https://www.npmjs.com/package/remark-preset-lint-markdown-style-guide and properly configured.

@DerekNonGeneric
Copy link
Member Author

[await import('remark-lint-code-block-style'), 'fenced'],

remark-lint-code-block-style

… is contained in https://www.npmjs.com/package/remark-preset-lint-markdown-style-guide and properly configured.

@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Aug 16, 2023

[await import('remark-lint-fenced-code-flag'), { flags: infoStrings }],

remark-lint-fenced-code-flag

… is contained in https://www.npmjs.com/package/remark-preset-lint-markdown-style-guide, but is improperly configured.

@DerekNonGeneric
Copy link
Member Author

await import('remark-lint-definition-spacing'),

remark-lint-definition-spacing

… is contained in https://www.npmjs.com/package/remark-preset-lint-markdown-style-guide and properly configured.

@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Aug 17, 2023

.github/.remarkrc.mjs

Lines 95 to 100 in bdf59bd

// Remark Lint Style Guide preset and overrides.
['remark-preset-lint-markdown-style-guide'],
['remark-lint-no-file-name-mixed-case', false],
['remark-lint-no-heading-punctuation', ':.,;'],
['remark-lint-no-file-name-irregular-characters', false],
['remark-lint-first-heading-level', 2],

remark-lint-no-file-name-irregular-characters

… is [indeed] contained in https://www.npmjs.com/package/remark-preset-lint-markdown-style-guide, however, perhaps improperly configured.

@DerekNonGeneric
Copy link
Member Author

We were not done quite yet; lingering deps likely remain & still not sparking joy over here!!

@DerekNonGeneric DerekNonGeneric added the backlog Issues and PRs, held in reserve, for future handling, processing, or repair label Aug 18, 2023
@DerekNonGeneric
Copy link
Member Author

Well, we will come back to this since i want to tackle it safely (proper isolation, containerization); moving progress here preferably doing OpenINF/docker-fisher#16 first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues and PRs, held in reserve, for future handling, processing, or repair bug Something isn't working javascript PRs that update JavaScript code linting Issues and PRs that deal with linting markdown An issue or PR related to Markdown tools Issues and PRs related to the tools directory
Projects
None yet
Development

No branches or pull requests

1 participant