-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with screenshot size #114
base: master
Are you sure you want to change the base?
Fix issue with screenshot size #114
Conversation
@scottwittenburg I've pulled and tried this on our integration environment. I've tried resizing my browser and taking various screen shots, and it's still sending images larger than 512x512 px. |
@jimklo That's because it depends on a change in vtk.js which isn't merged yet. As I mentioned in the description, we need that to get merged and generate a new version, then we can bump our dependency on vtk.js to pick it up. I changed this to a draft. |
15ce1ff
to
7911f44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this should now be working?
@dchiquito could you look over at this issue with help from @scottwittenburg and @dzenanz |
Currently just fixes the captured screenshot size at
512x512
, but could be extended in the future to allow the user to specify an arbitrary size. Depends on this PR getting merged into vtk.js, then we can bump the version we depend on here.Fixes #99