-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve screenshot options and capturing #18
Comments
Follow on of #4 |
@aashish24 regarding:
I would suggest supplying both a height and a width constraints. It should be possible to compute which way to scale based upon the the aspect ratio of the image. ie:
This way we might want to set height constraint to 512, but width constraint to 800. If you only want to set only one, choose height in lieu of width. Vertical space for most viewers is more limited than horizontal, Constraining the width could cause portrait oriented scan to resize much taller than desired, however a landscape image might be much smaller than desired. For Kilian's perspective, when reviewing screenshots via email, the vertical space is most important as he needs to be able to see the notes with the image without vertical scrolling. So in this case of a 4:3 viewport... having an image with a fixed height of 512 px (resulting in 683 px wide) would be preferred over fixing the width at 512, and ending up with an image thats 384 px tall. |
Thanks, these are excellent thoughts. I think from the simplicity point of view, I am in favor of just one so height would be the best pick as per your comment. Also, please note that I am hoping that we can get rid of most of the background space which will require camera to change its parameters. Would that be okay? |
I have sent an email to the vtk.js developers team to this end and now waiting for their evaluation. |
The browser size and host resolution seems to also still play a variable, as when I took snapshots using my iPad, the scan better fills the 512x512 box, however the image resolution seems low the size.
The text was updated successfully, but these errors were encountered: