Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssl.PROTOCOL_TLS, ssl.PROTOCOL_TLSv1_2, and so on are deprecated #719

Open
oittaa opened this issue Jul 27, 2024 · 1 comment
Open

ssl.PROTOCOL_TLS, ssl.PROTOCOL_TLSv1_2, and so on are deprecated #719

oittaa opened this issue Jul 27, 2024 · 1 comment

Comments

@oittaa
Copy link

oittaa commented Jul 27, 2024

All supported Python versions have deprecated TLS version specific configurations.

Deprecated since version 3.6: OpenSSL has deprecated all version specific protocols.

Clients should always use: ssl.PROTOCOL_TLS_CLIENT

Servers should always use: ssl.PROTOCOL_TLS_SERVER

https://docs.python.org/dev/library/ssl.html

@oittaa
Copy link
Author

oittaa commented Jul 28, 2024

I made auth_suite setting optional and it defaults to ssl.PROTOCOL_TLS_SERVER in #720 . You might want to put some kind of deprecation warning that Python will drop support of those older TLS settings at some point and everyone should just use the "secure by default" settings.

I also synced the patches from the propesed Python 3.12 support #707 but as I mentioned in the comments of the pull request, the tests are so complicated that I didn't really have time to figure out how to fix them. However my Synology NAS was able to connect to a server running my patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant