-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not rely on sqlx
database connection in client integration tests
#53
Comments
@joshuathayer thanks for your first contribution in #69! Feel free to pick this up as you suggested yourself. I'm happy to help you with any questions that might arise. |
Sounds good, I'll be happy to take a look at this in the coming days. In the issue description, you mention "the tests for |
Yes, you understand the description correctly. The reason is that we added the implementation and tests for |
The integration tests for
event
andprogram
in the VEN library rely on a DB created by the sqlx testing framework. This is not ideal, especially if we want to test the integration of our VEN library with a 3rd party VTN. Instead, the tests should rely on a running VTN instance and connect to a predefined URL.This also requires a predefined set of credentials with associated roles in the VTN, which the tests can rely on. Currently, they are created from the
test_user_credentials.sql
and applied in the CI before test execution.The tests must also run serially instead of in parallel, to avoid interference between them.
The tests for
resources
andven
do that already, though there might be room for improvement on how to design the tests exactly. Especially, a failing test may currently leave the VTN/DB in a different state than before.The text was updated successfully, but these errors were encountered: