Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used precise data type for price values #94

Open
pohlm01 opened this issue Nov 21, 2024 · 0 comments
Open

Used precise data type for price values #94

pohlm01 opened this issue Nov 21, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@pohlm01
Copy link
Member

pohlm01 commented Nov 21, 2024

The documentation specifies using floats for price values. We tried to get the specification changed to use integers and a precision parameter instead to avoid confusion and possible rounding errors, but we did not succeed.
Therefore, we have to ensure that we have precise decimal values for all price-related arguments within the codebase (maybe rust_decimal) as well as in the DB (likely decimal data type).

Depends on #93

https://github.com/oadr3-org/openadr3-openapi/discussions/183 (non-public)

@pohlm01 pohlm01 added enhancement New feature or request help wanted Extra attention is needed labels Nov 21, 2024
@pohlm01 pohlm01 moved this to Todo in OpenADR 3.0 Plan Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

1 participant