From ba5c383e8139f91236e82f13f7bddd804038dd19 Mon Sep 17 00:00:00 2001 From: DominikNoga Date: Wed, 4 Sep 2024 13:43:09 +0200 Subject: [PATCH] ANGOLASUP-909: added validation to prevent errors when no lineItems --- src/shipment-view/shipment-view.routes.js | 28 ++++++++++++----------- 1 file changed, 15 insertions(+), 13 deletions(-) diff --git a/src/shipment-view/shipment-view.routes.js b/src/shipment-view/shipment-view.routes.js index cfbd586..10c0b44 100644 --- a/src/shipment-view/shipment-view.routes.js +++ b/src/shipment-view/shipment-view.routes.js @@ -63,21 +63,23 @@ return unitOfOrderableService.getAll().then(function(response) { var unitsOfOrderable = response.content ? response.content : response; var index = 0; - stockCardSummaries.forEach(function(summary) { - summary.canFulfillForMe.forEach(function(canFulfill) { - var unitId = canFulfill.unitOfOrderable.id; - var currentItem = angular.copy(shipment.lineItems[index]); - currentItem.unitOfOrderableId = unitId; - currentItem.unit = unitsOfOrderable.find(function(unit) { - return unit.id === unitId; - }); - currentItem.packsQuantity = - Math.floor(currentItem.quantityShipped / currentItem.unit.factor); + if (shipment.lineItems && shipment.lineItems.length > 0) { + stockCardSummaries.forEach(function(summary) { + summary.canFulfillForMe.forEach(function(canFulfill) { + var unitId = canFulfill.unitOfOrderable.id; + var currentItem = angular.copy(shipment.lineItems[index]); + currentItem.unitOfOrderableId = unitId; + currentItem.unit = unitsOfOrderable.find(function(unit) { + return unit.id === unitId; + }); + currentItem.packsQuantity = + Math.floor(currentItem.quantityShipped / currentItem.unit.factor); - shipment.lineItems[index] = currentItem; - index++; + shipment.lineItems[index] = currentItem; + index++; + }); }); - }); + } return new ShipmentViewLineItemFactory().createFrom(shipment, stockCardSummaries); });