Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover message is different for versioned and version less features with compatible platform added #329

Open
JoshwinThomasIBM opened this issue Dec 12, 2024 · 4 comments
Labels
design enhancement New feature or request wontfix This will not be worked on

Comments

@JoshwinThomasIBM
Copy link

For version less feature servlet, with a compatible platform added, the description for the feature is different with the feature having versions, see the screenshots below
versionlessDescription
versionServletdescription

Expected that, on hover over the version less feature, it will give a description about the version with which it got resolved by adding the platform

@JoshwinThomasIBM JoshwinThomasIBM added enhancement New feature or request design labels Dec 12, 2024
@cherylking
Copy link
Member

Expected that, on hover over the version less feature, it will give a description about the version with which it got resolved by adding the platform

The description for a feature comes directly from the features.json file. This is working as expected. Frankly, it would be very very difficult for the language server to know what version was actually resolved for the feature (and that can be affected by multiple Liberty config files...not just the current one being edited). That would be a major enhancement request.

@cherylking cherylking added the wontfix This will not be worked on label Dec 19, 2024
@cherylking
Copy link
Member

cherylking commented Dec 19, 2024

One more point...the whole point of using versionless features is not needing to know which version of a feature to specify for a particular platform. So why would we need to resolve and display the version here in a language server? The appropriate version of the feature will be used for the specified platform. End of story.

@TrevCraw
Copy link
Contributor

@cherylking There may be other options here. I think the issue may be more that the description for the versionless feature is lacking compared to the versioned feature description. Maybe we should consider asking the Liberty team to add more info to the description for versionless features?

Out of curiosity, does Liberty output its resolved feature list anywhere? Not sure if anyone on our team would know the answer to that.

@cherylking
Copy link
Member

@TrevCraw You could ask the Liberty team to add info to the feature description. It is part of the json file that gets published in Maven Central.

When LMP or LGP gets invoked and features get installed, the list of resolved and installed features appears in the console output like the following:

For the following output, the server.xml contained these features/platforms:

<featureManager>
        <feature>restfulws-3.0</feature>
        <feature>jsonp-2.0</feature>
        <feature>jsonb-2.0</feature>
        <feature>cdi-3.0</feature>
        <feature>mpMetrics</feature>
        <feature>mpHealth</feature>
        <feature>mpConfig</feature>
        <platform>microProfile-5.0</platform>
    </featureManager>

Log message from LMP/LGP:

[INFO] Resolving features: [mphealth, jsonb-2.0, restfulws-3.0, jsonp-2.0, cdi-3.0, mpconfig, mpmetrics] using platforms: [microprofile-5.0]

followed by log message from LMP/LGP based on output from Liberty feature installation command:

[INFO] The following features have been installed: monitor-1.0 concurrent-2.0 transportSecurity-1.0 ssl-1.0 restfulWSClient-3.0 mpConfig-3.0 restfulWS-3.0 servlet-5.0 mpMetrics-4.0 json-1.0 distributedMap-1.0 cdi-3.0 jsonb-2.0 jndi-1.0 mpConfig mpMetrics mpHealth mpHealth-4.0 jsonp-2.0 

The following appears in the messages.log in the Liberty server for this use case:

[12/19/24, 10:41:20:082 CST] 00000028 com.ibm.ws.kernel.feature.internal.FeatureManager            I CWWKF0053I: Feature resolution selected the [jakartaee-9.1, microProfile-5.0] platforms.
[12/19/24, 10:41:20:082 CST] 00000028 com.ibm.ws.kernel.feature.internal.FeatureManager            I CWWKF0051I: The [mpHealth, mpMetrics, mpConfig] versionless features resolved to [mpHealth-4.0, mpMetrics-4.0, mpConfig-3.0]
[12/19/24, 10:41:20:083 CST] 00000028 com.ibm.ws.kernel.feature.internal.FeatureManager            A CWWKF0012I: The server installed the following features: [cdi-3.0, concurrent-2.0, distributedMap-1.0, jndi-1.0, json-1.0, jsonb-2.0, jsonp-2.0, monitor-1.0, mpConfig-3.0, mpHealth-4.0, mpMetrics-4.0, restfulWS-3.0, restfulWSClient-3.0, servlet-5.0, ssl-1.0, transportSecurity-1.0].
[12/19/24, 10:41:20:083 CST] 00000028 com.ibm.ws.kernel.feature.internal.FeatureManager            I CWWKF0008I: Feature update completed in 1.741 seconds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants