Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking MP config props link in hover opens file:///... URL in browser rather than opening file in IDE source editor #191

Open
scottkurz opened this issue Oct 23, 2022 · 2 comments
Labels
bug Something isn't working with the product

Comments

@scottkurz
Copy link
Member

scottkurz commented Oct 23, 2022

With the MP LS hover support for config props, hovering over the 'name' attribute String value pops up help text that appears to read like Javadoc-style info, with a file URL link.

E.g. I might see something like:

abc=23 in META-INF/microprofile-config.properties

where META-INF/microprofile-config.properties is hyperlinked to a URL: file:///<path-to-proj-home>/src/main/resources/META-INF/microprofile-config.properties.

If I click on this it opens the file in a browser. However it would be more useful to open in the IDE editor.

Assuming this would likely need to be addressed in the LSP4MP source though not knowing for sure, it is conceivable at least there might be an Eclipse preference that could be relevant.

Opened here to track until we open an issue with LSP4MP

@scottkurz scottkurz added the bug Something isn't working with the product label Oct 23, 2022
@scottkurz scottkurz added this to the EOY 2022 GA milestone Oct 23, 2022
@scottkurz
Copy link
Member Author

@kathrynkodama do you have any experience with this kind of issue ? Does the LSP have guidance on what type of "links" can be passed to project files within the workspace? I'm thinking if there's an Eclipse-specific value that'd be helpful here, well, the LSP wouldn't supply it from the IDE-neutral level.. so how would the Eclipse-specific value get generated (by whom)?

@scottkurz
Copy link
Member Author

One angle to start with would be to see if there's a more general (not necessarily LSP-specific) preference in Eclipse specifically to open a file: URL within the workspace... even if this might require installing some other plugin.

I'm not sure from the IDE-neutral LSP impl view we'd want to supply a different string here, so this might end up being the best we can do.

@scottkurz scottkurz added idea and removed bug Something isn't working with the product labels Nov 28, 2022
@scottkurz scottkurz removed this from the EOY 2022 GA milestone Nov 28, 2022
@scottkurz scottkurz added bug Something isn't working with the product and removed idea labels Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working with the product
Projects
None yet
Development

No branches or pull requests

1 participant