Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WDT + Liberty Tools Eclipse co-existence - server.xml double-click opens in WDT Liberty Configuration Editor rather than Generic Text Editor w/ LSP #202

Open
scottkurz opened this issue Oct 23, 2022 · 2 comments
Labels
bug Something isn't working with the product

Comments

@scottkurz
Copy link
Member

TODO - provide recreate function. We'd have to go back to 2022-06 and Liberty Tools Eclipse v0.2 at this point.

Probably a low priority issue since WDT won't reach 2022-09 compat for some time.

@scottkurz scottkurz added this to the EOY 2022 GA milestone Oct 23, 2022
@scottkurz scottkurz added the bug Something isn't working with the product label Oct 25, 2022
@scottkurz
Copy link
Member Author

We can pull this off the milestone and deal with in '23.

@scottkurz scottkurz removed this from the EOY 2022 GA milestone Nov 15, 2022
@scottkurz scottkurz added this to the 24.0.3 milestone Mar 11, 2024
@scottkurz
Copy link
Member Author

One option would be to override the content type bindings for the content types defined in https://github.com/OpenLiberty/open-liberty-tools/blob/integration/dev/com.ibm.ws.st.core/plugin.xml
(copied below), to bind them to the generic text editor.

Perhaps we should do a design issue discussion first though.

  <extension point="org.eclipse.core.contenttype.contentTypes">
    <content-type
      id="com.ibm.ws.st.configuration"
      name="%contentType"
      file-extensions="xml"
      priority="normal"
      default-charset="UTF-8"
      base-type="org.eclipse.core.runtime.xml">
      <describer class="org.eclipse.core.runtime.content.XMLRootElementContentDescriber">
        <parameter name="element" value="server"/>
      </describer>
    </content-type>
    <content-type
      id="bootstrap.properties"
      name="%bootstrapContentType"
      priority="normal"
      default-charset="UTF-8"
      file-names="bootstrap.properties"
      base-type="org.eclipse.core.runtime.properties"/>
    <content-type
      id="jvm.options"
      name="%jvmOptionsContentType"
      priority="normal"
      default-charset="UTF-8"
      file-names="jvm.options"
      base-type="org.eclipse.core.runtime.properties"/>
    <content-type
      id="server.env"
      name="%serverEnvContentType"
      priority="normal"
      default-charset="UTF-8"
      file-names="server.env"
      base-type="org.eclipse.core.runtime.properties"/>
  </extension>

@scottkurz scottkurz modified the milestones: 24.0.3, 24.0.6 Mar 11, 2024
@scottkurz scottkurz modified the milestones: 24.0.6, 24.0.9 Apr 26, 2024
@awisniew90 awisniew90 modified the milestones: 24.0.9, 24.0.12 Sep 24, 2024
@awisniew90 awisniew90 modified the milestones: 24.0.12, 25.0.4 Nov 20, 2024
@awisniew90 awisniew90 removed this from the 25.0.4 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working with the product
Projects
None yet
Development

No branches or pull requests

2 participants