-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add debug restart #508
base: main
Are you sure you want to change the base?
Add debug restart #508
Conversation
This is a nice improvement on the HCR failure path. Now that I appreciate the use case better... I can also appreciate that it still leaves say the path in which dev mode restarts the server upon a bootstrap.properties update. Let's think about that more. |
cd61919
to
5ce2066
Compare
bundles/io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/DevModeOperations.java
Outdated
Show resolved
Hide resolved
....openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/debug/LibertyDebugTarget.java
Show resolved
Hide resolved
...io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/debug/DebugModeHandler.java
Show resolved
Hide resolved
...io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/debug/DebugModeHandler.java
Outdated
Show resolved
Hide resolved
...io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/debug/DebugModeHandler.java
Outdated
Show resolved
Hide resolved
5c608df
to
c95e3ee
Compare
Signed-off-by: Adam Wisniewski <[email protected]>
Signed-off-by: Adam Wisniewski <[email protected]>
Just capturing that we reviewed this today and thought it'd be good to get rid of the automatic reconnect on disconnect. We can still have the overloaded reconnect selection button on HCR failure. We also are good with the idea that each Run/Debug config can define its own reconnect/disconnect behavior, so us defining our own is fine from that POV. |
Signed-off-by: Adam Wisniewski <[email protected]>
c95e3ee
to
b33798e
Compare
Signed-off-by: Adam Wisniewski <[email protected]>
Signed-off-by: Adam Wisniewski <[email protected]>
Signed-off-by: Adam Wisniewski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See what you think.
...io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/debug/DebugModeHandler.java
Show resolved
Hide resolved
...io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/debug/DebugModeHandler.java
Show resolved
Hide resolved
...s.eclipse.ui/src/io/openliberty/tools/eclipse/debug/LibertyDebugReconnectActionDelegate.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Adam Wisniewski <[email protected]>
Signed-off-by: Adam Wisniewski <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - will run one more set of tests when we think we're done.
Fixes #498
This PR creates the following behaviors:
2. A restart of the server from dev mode via the command line will result in the debugger being disconnected and reconnected when the server restarts (using whatever debug port dev mode chose)3. When in debug mode, the debugger is always on.... if disconnected (automatically or manually), it will always attempt to reconnect.After reviewing, it seemed overkill to attempt to reconnect the debugger on every disconnect. This also created issues when intentionally disconnecting the debugger. In place of number 2 and 3 above, we are instead adding a "Connect Liberty Debugger" action to the Debug view context menu. If the debugger is disconnected (due to a restart of the server or manual disconnect), a user can now reconnect without having to stop and start the application via the Dashboard.
----- More Details ------
In the second rendition of the Liberty Tools debugger (prior to this PR), the debugger was combined with the Maven/devmode process into one launch configuration. This meant that the lifecycle of the two processes were tightly coupled causing undesired behavior. For example, a disconnect of the debugger triggered a full termination of the application running in Maven. 3 ways this disconnect could happen is either via a HCR failure, a restart of the server via devmode, or a manual disconnect via the debug view context menu.
This PR makes the following improvements: