Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hover on text: 'wrong' did not trigger a pop-up window to open in testQuickFixInServerXML() and testDiagnosticInServerXML() #1204

Open
anusreelakshmi934 opened this issue Dec 23, 2024 · 7 comments
Labels
automated tests bug Something isn't working
Milestone

Comments

@anusreelakshmi934
Copy link
Contributor

java.lang.RuntimeException: Hover on text: 'wrong' did not trigger a pop-up window to open
Caused by:
com.intellij.remoterobot.utils.WaitForConditionTimeoutException: Exceeded timeout (PT5S) for condition function (Failed to find 'Container' by '//div[@Class='HeavyWeightWindow']//div[@Class='JEditorPane']' in 5s)

@staicy123
Copy link
Contributor

GradleSingleModLSTest > testQuickFixInServerXML() FAILED
java.lang.RuntimeException: Hover on text: 'wrong' did not trigger a pop-up window to open
at io.openliberty.tools.intellij.it.UIBotTestUtils.hoverForQuickFixInAppFile(UIBotTestUtils.java:893)
at io.openliberty.tools.intellij.it.SingleModLibertyLSTestCommon.testQuickFixInServerXML(SingleModLibertyLSTestCommon.java:306)
Cron Job link:
https://github.com/OpenLiberty/liberty-tools-intellij/actions/runs/12667843593/job/35302020393

@staicy123
Copy link
Contributor

staicy123 commented Jan 14, 2025

I am attaching videos for bug mentioned in this issue.
Issue demonstrate that suggestions are not appearing as expected, which is causing the tests to fail.

testQuickFixInServerXML_recording_2025_08_01_11_09_08.mov

@staicy123
Copy link
Contributor

staicy123 commented Jan 16, 2025

The cron job failure reported appears to be related to the LTI version 24.0.9 and Liberty Language Server version liberty-langserver:2.1.2. I attempted to replicate the issue locally using the same versions but was unable to do so, as the problem seems intermittent.

To further investigate, I checked the latest changes in both LTI and LSP4IJ repositories but did not find any issues directly related to the reported failure. Based on this, I suspect the issue may have been resolved in the newer Liberty Language Server version (liberty-langserver:2.2), which is being used in the latest builds.

I recommend monitoring the issue with the latest version of the language server, and should the failure recur, we can investigate it further. For now, it seems that the issue might not be present in the current build.

@vaisakhkannan
Copy link
Contributor

vaisakhkannan commented Jan 27, 2025

Out of 20 build I ran today on windows , 1 build is having 2 failures and those are unique failure compared to other 19 builds

GradleSingleModLSTest > testDiagnosticInServerXML() FAILED
    java.lang.RuntimeException: Hover on text: wrong did not trigger a pop-up window to open
 GradleSingleModLSTest > testServerXMLNonFeatureHover() FAILED
    java.lang.RuntimeException: Hover on text: httpEndpoint did not trigger a pop-up window to open

Build link : https://github.com/vaisakhkannan/liberty-tools-intellij/actions/runs/12985114191/job/36209316139

So this test failure is an intermittent issue and could not reproducible locally

@staicy123
Copy link
Contributor

staicy123 commented Jan 30, 2025

Hi @turkeylurkey,

I have analyzed this issue based on the latest changes in the main branch and the cron job executions. However, I was unable to reproduce the issue in my testing. That said, as noted in Vaishak’s comment, he was able to reproduce the issue in one of the 20 builds executed.

As per our previous discussion, we had agreed to close the issue if it was not occurring in the latest build and reopen it if it reappeared. Given that Vaishak has encountered the issue again, could you please advise on the next steps?
cc: @TrevCraw, @dessina-devasia

Thanks

@staicy123 staicy123 moved this from In Progress to Parked in Open Liberty Developer Experience Jan 30, 2025
@staicy123 staicy123 removed their assignment Jan 30, 2025
@TrevCraw
Copy link
Contributor

Thank you @staicy123.

@dessina-devasia @vaisakhkannan Let's have the team keep an eye out for this failure on any PR or cron job build runs for the next week. We can discuss at the beginning of next sprint whether to keep open or close.

@dessina-devasia
Copy link
Contributor

sure @TrevCraw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automated tests bug Something isn't working
Projects
Development

No branches or pull requests

5 participants