Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Internal and Deprecated APIs #1086

Open
vaisakhkannan opened this issue Nov 7, 2024 · 3 comments · May be fixed by #1206
Open

Fix Internal and Deprecated APIs #1086

vaisakhkannan opened this issue Nov 7, 2024 · 3 comments · May be fixed by #1206
Assignees
@anusreelakshmi934
Labels
automated tests Deprecated API's Deprecated API usage in LTI enhancement New feature or request
Milestone
CI/CD Next

Comments

@vaisakhkannan
Copy link
Contributor

Found a method which is marked as @ApiStatus.Internal

liberty-tools-intellij/src/test/java/io/openliberty/tools/intellij/lsp4jakarta/it/core/BaseJakartaTest.java

Line 118 in 001047d

File moduleDir = new File(module.getModuleFilePath()).getParentFile();

Screenshot 2024-11-07 at 6 24 09 PM

Find other similar usages and Fix the issue
@vaisakhkannan
Copy link
Contributor Author

vaisakhkannan commented Nov 7, 2024 •
edited
Loading

Jetbrains may reject plugins using Internal APIs , see their announcement here in the slack channel

@TrevCraw
Copy link
Contributor

TrevCraw commented Nov 7, 2024

@vaisakhkannan I am not able to access that Slack message, could you please paste it in the issue?

@TrevCraw TrevCraw added enhancement New feature or request Deprecated API's Deprecated API usage in LTI automated tests labels Nov 7, 2024
@vaisakhkannan
Copy link
Contributor Author

@TrevCraw :

Screenshot 2024-11-07 at 10 57 11 PM

@mrglavas mrglavas changed the title Fix Internal and Depricated APIs Fix Internal and Deprecated APIs Dec 2, 2024
@TrevCraw TrevCraw added this to the CI/CD Next milestone Dec 28, 2024
@anusreelakshmi934 anusreelakshmi934 self-assigned this Jan 2, 2025
@anusreelakshmi934 anusreelakshmi934 linked a pull request Jan 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anusreelakshmi934 anusreelakshmi934

Labels
automated tests Deprecated API's Deprecated API usage in LTI enhancement New feature or request
Projects
Open Liberty Developer Experience
Status: New Issues
Milestone
CI/CD Next
3 participants
@TrevCraw @vaisakhkannan @anusreelakshmi934