Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code to use the latest lsp4ij from Microshed #592

Closed
22 tasks done
turkeylurkey opened this issue Nov 30, 2023 · 4 comments
Closed
22 tasks done

Update code to use the latest lsp4ij from Microshed #592

turkeylurkey opened this issue Nov 30, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request Epic high priority language client language server integration lsp4ij

Comments

@turkeylurkey
Copy link
Member

turkeylurkey commented Nov 30, 2023

There is an lsp4ij branch on Microshed that uses the lsp4ij code from 11/01.

Update this tool to make use of that. This mainly affects the MicroProfile support (e.g. lsp4mp4ij) but these changes will also affect the other language servers.

Issues required to close this item:

This issue is to be marked complete only when the useLSP4IJ1201 feature branch has been merged into main.

After merging, we should check old "language client" bugs to see if the LSP4IJ update has resolved them or not. (Incomplete - work item open to address later: #732)

@turkeylurkey turkeylurkey added enhancement New feature or request language client language server integration labels Nov 30, 2023
@turkeylurkey turkeylurkey self-assigned this Nov 30, 2023
@turkeylurkey
Copy link
Member Author

After merging the latest lsp4mp4ij code and the MicroProfile client code

  1. the MicroProfile support produces diagnostics and completion
  2. The Jakarta diagnostics only appear if you perform some other action in the Java file like hover or completion.
  3. The LCLS diagnostics appear in bootstrap.properties after you perform hover or completion.
  4. The lemminx diagnostics do appear when you open server.xml.

@turkeylurkey
Copy link
Member Author

turkeylurkey commented Nov 30, 2023

ToDo:

  • start Jakarta language server when a Java file is opened
  • start the LCLS language server when a properties file is opened
  • start the lemminx server when an XML file is opened

@turkeylurkey
Copy link
Member Author

turkeylurkey commented Dec 15, 2023

Liberty Config
XML:

  • diagnostics
  • xml completion
  • feature completion in server.xml
  • hover

Properties:

@turkeylurkey
Copy link
Member Author

The lsp4ij project on Microshed has the lsp4ij code from 12/01 (with some fixes) on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic high priority language client language server integration lsp4ij
Projects
Status: Done
Development

No branches or pull requests

3 participants