Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTI 24.0.9: Align LSP4iJ, LSP4MP4iJ and LSP4MP for the release. #841

Closed
4 tasks done
mrglavas opened this issue Jun 25, 2024 · 5 comments
Closed
4 tasks done

LTI 24.0.9: Align LSP4iJ, LSP4MP4iJ and LSP4MP for the release. #841

mrglavas opened this issue Jun 25, 2024 · 5 comments
Assignees
Labels
Milestone

Comments

@mrglavas
Copy link
Contributor

mrglavas commented Jun 25, 2024

Current versions of the components on or being consumed by the LTI development stream:

LSP4iJ: 0.0.2
LSP4MP4iJ: snapshot taken on an arbitrary day from the Quarkus Tools main branch to match up with LSP4iJ 0.0.2
LSP4MP: 0.12.0-SNAPSHOT

============

Regarding LSP4iJ, there are a couple open issues we've been tracking:
redhat-developer/lsp4ij#294
redhat-developer/lsp4ij#324

We would prefer to resolve redhat-developer/lsp4ij#294 before releasing and through testing we may identify additional issues that would impact the LTI release. This would require moving up to a future release of LSP4iJ (0.3.0?, 0.3.1?) which contains the fixes we require. That is the ideal outcome. We should get an understanding of what is likely to be available from LSP4iJ in the near future and assess whether that will be adequate from an LTI release.

============

Regarding LSP4MP4iJ, we should ideally be basing our snapshot off a release of Quarkus Tools so that it is easy to map this component back to its original source and also represents a version that Red Hat published to the Marketplace. We should check with the Quarkus Tools team on whether there is a release coming soon that we could align with.

============

Regrading LSP4MP, we prefer to have a dependency on a released version of LSP4MP. Currently we're relying on a snapshot of 0.12.0. We should ask the community whether the 0.12.0 is expected soon. The most recent release at the time of this writing appears to be: https://github.com/eclipse/lsp4mp/releases/tag/0.11.3. If 0.12.0 will not be available soon, we should determine if we can align with LSP4MP 0.11.3. Ideally we would align with LSP4MP 0.12.0 because LSP4MP4iJ is currently pulling in a snapshot of this release.

============

What we actually end up doing here depends very much on the activity in each of these dependencies. I've mostly focused on the ideal outcomes but we may need to consider alternatives in order to move forward.

============
Work items:

@mrglavas
Copy link
Contributor Author

mrglavas commented Jun 27, 2024

@angelozerr I think you're probably aware that we've been copying LSP4MP4iJ from Quarkus Tools for Microprofile support. As we've been working an adoption of LSP4iJ we have been taking snapshots from Quarkus Tools main, but now as we're heading towards a release which will use LSP4iJ 0.2.0 (or later) we're hoping to align with a release of Quarkus Tools if possible. We're curious if a new release might be on the horizon. Similarly, we noticed that Quarkus Tools has a dependency on 0.12.0-SNAPSHOT of LSP4MP and are curious if LSP4MP 0.12.0 might be released soon. We have also been pulling this dependency into our development stream but would want to be picking up a released version of LSP4MP when we release LTI.

@angelozerr
Copy link

@angelozerr I think you're probably aware that we've been copying LSP4MP4iJ from Quarkus Tools for Microprofile support. As we've been working an adoption of LSP4iJ we have been taking snapshots from Quarkus Tools main, but now as we're heading towards a release which will use LSP4iJ 0.2.0 (or later) we're hoping to align with a release of Quarkus Tools if possible. We're curious if a new release might be on the horizon. Similarly, we noticed that Quarkus Tools has a dependency on 0.12.0-SNAPSHOT of LSP4MP and are curious if LSP4MP 0.12.0 might be released soon. We have also been pulling this dependency into our development stream but would want to be picking up a released version of LSP4MP when we release LTI.

@mrglavas my previous goal was to create a robust (I hope) release for LSP4IJ but now my main goal is to do a release of IJ Quarkus ASAP to consume LSP4IJ, but before I need to fix some important issues for Qute and after that we will release LSP4MP etc but I cannot give you a date

@mrglavas
Copy link
Contributor Author

mrglavas commented Jul 24, 2024

Based on our recent discussions with the team and @fbricon we're currently targeting (as of 2024-08-21):

  • LSP4iJ 0.4.0 available from the JetBrains Marketplace.
  • LSP4MP4iJ: the next IntelliJ Quarkus Tools release to align with a versioned level of LSP4MP IntelliJ client code and usage of LSP4iJ 0.4.0.
  • LSP4MP 0.12.0 which would be aligned with the IntelliJ Quarkus Tools release.

@TrevCraw TrevCraw added the Epic label Aug 14, 2024
@mrglavas mrglavas changed the title LTI 24.0.7: Align LSP4iJ, LSP4MP4iJ and LSP4MP for the release. LTI 24.0.8: Align LSP4iJ, LSP4MP4iJ and LSP4MP for the release. Aug 14, 2024
@TrevCraw TrevCraw changed the title LTI 24.0.8: Align LSP4iJ, LSP4MP4iJ and LSP4MP for the release. LTI 24.0.9: Align LSP4iJ, LSP4MP4iJ and LSP4MP for the release. Aug 26, 2024
@TrevCraw TrevCraw assigned mrglavas and aparnamichael and unassigned mrglavas Aug 26, 2024
@aparnamichael aparnamichael moved this from Parked to In Progress in Open Liberty Developer Experience Aug 27, 2024
@aparnamichael
Copy link
Contributor

aparnamichael commented Aug 27, 2024

LSP4MP4IJ - new commits after Jun 4.

Commits on Aug 26, 2024

Commits on Aug 21, 2024

Commits on Aug 20, 2024

Commits on Aug 19, 2024

Commits on Aug 7, 2024

Commits on Jul 27, 2024

Commits on Jul 13, 2024

Commits on Jul 11, 2024

Commits on Jul 9, 2024

Commits on Jul 8, 2024

Commits on Jul 4, 2024

Commits on Jul 1, 2024

Commits on Jun 13, 2024

@aparnamichael
Copy link
Contributor

Updated the lsp4mp4ij and lsp4mp

@github-project-automation github-project-automation bot moved this from In Review to Sprint Closed in Open Liberty Developer Experience Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

4 participants