Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fixes are available for platforms and the suggestions are from features list and choosing one causes error #350

Closed
Tracked by #342
JoshwinThomasIBM opened this issue Oct 17, 2024 · 4 comments · Fixed by OpenLiberty/liberty-language-server#311
Assignees
Labels
bug Something isn't working language client language server integration
Milestone

Comments

@JoshwinThomasIBM
Copy link
Contributor

JoshwinThomasIBM commented Oct 17, 2024

  1. Added the platform Jakartaee
image

Removed the version and got the diagnostics
image

Here the quick fixes are available and the is listed from the features list
image

if we choose one we can see the diagnostics as the platform doesn't exist, see below
image

  1. Gave javaee as a version less platform
image

below are the quick fixes suggested
image

Along with platform suggestions , it also lists the features in quick fixes and choosing the one's from the features will show the diagnostics as the platform doest exist, see below

image
  1. Also the the message for the quick fixes in platform is displayed as "Replace feature "
image

if quick fixes are implemented for platforms, then the message can be "Replace platform"

@arunvenmany-ibm
Copy link

Hi @cherylking

I think there is 2 ways to fix this

  1. remove replace code action for invalid platform
  2. add new type of liberty error code for invalid platform and add logic to replace platform
    a. if user has entered a sub set of valid platform ( such as javae or jakarta) then show platforms which are similar to input in replace options
    b. if user has entered a completely invalid platform( such as abcde or javaef), then show all platforms in replace options

Please let me know If I can go ahead with this

@TrevCraw
Copy link
Contributor

Was quick fix functionality for the platform element intended to be delivered for versionless feature support?

@dessina-devasia
Copy link

Similar LTI issue
OpenLiberty/liberty-tools-intellij#1034

@JoshwinThomasIBM
Copy link
Contributor Author

Tested with the latest LCLS snapshot and the above issues are fixed , see below
image

@TrevCraw TrevCraw added this to the 24.0.11 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working language client language server integration
Projects
Development

Successfully merging a pull request may close this issue.

4 participants