Enhancing the ignoreWriteAfterCommit property #30896
Draft
+41
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsaldana
reviewed
Feb 28, 2025
...bm.ws.transport.http/src/com/ibm/ws/http/channel/internal/outbound/HttpOutputStreamImpl.java
Show resolved
Hide resolved
mrsaldana
reviewed
Feb 28, 2025
...bm.ws.transport.http/src/com/ibm/ws/http/channel/internal/outbound/HttpOutputStreamImpl.java
Outdated
Show resolved
Hide resolved
|
#build (view Open Liberty Personal Build - ❌ completed with errors/failures.) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
seshadhri-aswath
changed the title
|
#build (view Open Liberty Personal Build - ⏳InProgress) Note: Target locations of links might be accessible only to IBM employees. |
|
#fullpb (view Open Liberty Personal Build - ⏳InProgress) Note: Target locations of links might be accessible only to IBM employees. |
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
1 similar comment
Code analysis and actionsDO NOT DELETE THIS COMMENT.
|
mrsaldana
reviewed
Mar 3, 2025
| @@ -213,7 +213,7 @@ public class HttpChannelConfig { | |||
| private HashSet<String> configuredHeadersErrorSet = null; | |||
| /** Identifies if the transport will ignore writes if the message has been committed. When false, an exception | |||
| * is expected to be thrown marking the invalid state. */ | |||
| private boolean ignoreWriteAfterCommit = false; | |||
| private boolean ignoreWriteAfterCommit = true; | |||
There was a problem hiding this comment.
Why is the default value being set to true on this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
release buglabel if applicable: https://github.com/OpenLiberty/open-liberty/wiki/Open-Liberty-Conventions).Fixes #30871