Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FirmwareMaster blockId issue #19

Open
mcallegari opened this issue Jul 7, 2022 · 0 comments · May be fixed by #21
Open

FirmwareMaster blockId issue #19

mcallegari opened this issue Jul 7, 2022 · 0 comments · May be fixed by #21

Comments

@mcallegari
Copy link

Hi, this line of code is suspicious:

firm->expected_block %= UINT8_MAX;

It means blockId will never reach 255, but just 254.
I tested the code with a few fixtures and they errored on the 254 -> 0 switch.
Any chance this can be fixed for future versions?
Thanks

@FloEdelmann FloEdelmann linked a pull request Apr 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant