Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean Flags for TOPP tools are not working #90

Open
t0mdavid-m opened this issue Nov 8, 2024 · 1 comment
Open

Boolean Flags for TOPP tools are not working #90

t0mdavid-m opened this issue Nov 8, 2024 · 1 comment
Assignees

Comments

@t0mdavid-m
Copy link
Member

If boolean parameters are adjusted within the TOPP tool framework, the framework attempts to set the flags explicitly, which is not expected by TOPP tools and leads to errors:

true values:
Current Output: -myflag true
Expected by TOPP: -myflag

false values:
Current Output: myflag false
Expected by TOPP: (omission)

It seems like we cannot distinguish boolean values from string values from the respective ini files (#59). Thus, for FLASHViewer we went with rules for the parameters values "true" and "false" (see d1a85b9). However, this solution could cause issues in scenarios where the values "true" or "false" should be actual strings.

I would assume that this a rare case but also wanted to see if anyone else has another opinion?

@cbielow
Copy link

cbielow commented Nov 8, 2024

Ideas:

  1. create an INI file (which uses true/false internally) with your parameters and pass that on the commandline
  2. inspect the INI file, to determine the value type (a flag will have <ITEM name="..." type="bool" ....>
  3. just annotate params in streamlit 'manually' as what they are and use that annotation when invoking the TOPP tool (least stable nor fun solution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants