Drop Varien_Profiler?

[kyrena]

It's a question for the core.

[fballiano]

I'd agree to drop it, it seems to me something from another age and it has many many calls all over the core

[Flyingmana]

It was back then used quite a bit, and most of the Magento 1 specific profiling solutions hook into it.

But with xdebug, as well as modern tracing solutions, there is likely no need for it anymorw

[kiatng]

May be for the next branch?

[empiricompany]

Wait, but after even this extension that I use a lot wouldn't work, right?
https://github.com/madalinoprea/magneto-debug
It's useful in production when I'm not loading the xdebug extension.
Is there a performance reason? If disabled, I think it does not have an impact on performance.

[empiricompany]

I was asking because the last update is from 2017

I know but just it works :)

[fballiano]

tested it, notes:

• without varien_profiler it won't work
• execution time is always zero
• database query explain triggers an error each time
• seems to work also removing all the calls to varien_profiler::start()/stop() but it won't work without the varien_profiler class itself

so an option could be remove all of this "fake" calls:

but keep the varien_profiler class

[empiricompany]

we also need to consider that I have seen 3rd party extensions make use of varien_profiler

[sreichel]

@fab Fake/Test calls can be removed, but I would keep it for easy debugging. Small shops do not use Blackfire, newrelic and xdebug is often disabled in production.

[pquerner]

https://github.com/AOEpeople/Aoe_Profiler is also a thing.

[pquerner]

Not sure about removing. I think the way it works right now (for single calls, behind dev mode, whatnot) its only "many" code lines and calls which in production go to the void. Does that add up in the request? Perhaps. But I think (dont have numbers to back this) its very very tiny.

[Flyingmana]

likely in the amount of less then a ms, and with modern opcache optimization active, it might not even get actually executed when not activated.

[addison74]

From what I can see, it is used in several places, including in this PR #3530. It is possible to be used in extensions that we do not know about. I wouldn't rush to remove it from the core.