-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize Message Detailing and Simplification #2512
Comments
Has anyone started working on this issue? If not, can I take this on? |
I will work on it anyways then... Hopefully no doubly duplicated efforts. |
@kakirastern Hi. Are you still working on this? |
@suhacker1 No, not anymore. |
@suhacker1 We're in the process of migrating from msgpack to Protobuf in part to improve performance, so optimizing msgpack might not make sense any more. Happy to help you get started working on Protobuf if you want though. |
@karlhigley Have we had an open issue for that? I would love to try. |
See OpenMined/syft-proto#35 for details on the Protobuf effort. |
Is your feature request related to a problem? Please describe.
At present, most of our Message types use a simple/default simplification/detailing process. It's very likely that this is calling simplify() and detail() on objects which are already simple enough (which is not very efficient).
Describe the solution you'd like
For each TODO marked with this issue inside of syft/messaging/message.py, see if you can find the optimal detail and simplify method for each message type.
Describe alternatives you've considered
It's possible they're already optimal./
Additional context
You should run a benchmark on performance to double check your improvements actually translate into a speed increase.
The text was updated successfully, but these errors were encountered: