Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize Message Detailing and Simplification #2512

Closed
iamtrask opened this issue Aug 15, 2019 · 7 comments
Closed

Optimize Message Detailing and Simplification #2512

iamtrask opened this issue Aug 15, 2019 · 7 comments
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: New Feature ➕ Introduction of a completely new addition to the codebase

Comments

@iamtrask
Copy link
Member

Is your feature request related to a problem? Please describe.
At present, most of our Message types use a simple/default simplification/detailing process. It's very likely that this is calling simplify() and detail() on objects which are already simple enough (which is not very efficient).

Describe the solution you'd like
For each TODO marked with this issue inside of syft/messaging/message.py, see if you can find the optimal detail and simplify method for each message type.

Describe alternatives you've considered
It's possible they're already optimal./

Additional context
You should run a benchmark on performance to double check your improvements actually translate into a speed increase.

@iamtrask iamtrask added Type: New Feature ➕ Introduction of a completely new addition to the codebase Good first issue 🎓 Perfect for beginners, welcome to OpenMined! labels Aug 15, 2019
@kakirastern
Copy link
Contributor

Has anyone started working on this issue? If not, can I take this on?

@kakirastern
Copy link
Contributor

I will work on it anyways then... Hopefully no doubly duplicated efforts.

@suhacker1
Copy link

@kakirastern Hi. Are you still working on this?

@kakirastern
Copy link
Contributor

@suhacker1 No, not anymore.

@karlhigley
Copy link
Contributor

@suhacker1 We're in the process of migrating from msgpack to Protobuf in part to improve performance, so optimizing msgpack might not make sense any more. Happy to help you get started working on Protobuf if you want though.

@duynht
Copy link

duynht commented Mar 27, 2020

@karlhigley Have we had an open issue for that? I would love to try.

@karlhigley
Copy link
Contributor

See OpenMined/syft-proto#35 for details on the Protobuf effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: New Feature ➕ Introduction of a completely new addition to the codebase
Projects
None yet
Development

No branches or pull requests

5 participants