Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Concept 16 of Modular Algebra #327

Open
hwrdtm opened this issue May 10, 2021 · 0 comments
Open

Fix typo in Concept 16 of Modular Algebra #327

hwrdtm opened this issue May 10, 2021 · 0 comments
Labels
Type: Bug 🐛 Some functionality not working in the codebase as intended

Comments

@hwrdtm
Copy link

hwrdtm commented May 10, 2021

Description

There is a typo in the video and notebook used in the concept 16 lesson (https://courses.openmined.org/courses/foundations-of-private-computation/50502950-48c7-488c-b6d8-ea512b7fd84f/4d261b23-c978-421c-aeeb-08394339fd51). The typo is also surfaced in this discussion: #312.

Expected Behavior

Change

For random 𝑎 the probability for it not being a witness is 25%, therefore the probability of not finding 10 witnesses at random if 𝑎 is composite is 0.25^10, i.e. If no witnesses are found in 10 rounds, then the probability for 𝑎 being prime is 1−0.2510= 0.999999

to

For random 𝑎 the probability for it not being a witness is 25%, therefore the probability of not finding 10 witnesses at random if n is composite is 0.25^10, i.e. If no witnesses are found in 10 rounds, then the probability for n being prime is 1−0.2510= 0.999999

@hwrdtm hwrdtm added the Type: Bug 🐛 Some functionality not working in the codebase as intended label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug 🐛 Some functionality not working in the codebase as intended
Projects
None yet
Development

No branches or pull requests

1 participant