Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some(?) models seem to have their discriminators posted as separate models #278

Open
joeyballentine opened this issue Sep 18, 2023 · 2 comments

Comments

@joeyballentine
Copy link
Contributor

Example: https://openmodeldb.info/models/2x-VimeoScale-Unet

@ferrosa
Copy link

ferrosa commented Sep 19, 2023

As per chaiNNer-org/chaiNNer#2228 (comment) and also the model tag, this doesn't appear to be a discriminator, but a SOFVSR model.
I guess the issue is that not all .pth models are equal and users are left unguided.
In particular: chaiNNer can't run this one.
Maybe a "compatible with chaiNNer 0.X.Y+" tag/filter option (or a tools compatibility checklist... hellish to maintain), but that's off issue.

@joeyballentine
Copy link
Contributor Author

I guess the issue is that not all .pth models are equal and users are left unguided.

.pth files are just model weights. They contain no information about what the model is supposed to be, what kind of input it needs, etc. It's just a bunch of numbers meant to be fed into the model structure (technically it's a bunch of key/value pairs of tensors). This means that to use a model, you need to support its architecture, and you cant just use random models with random programs. chaiNNer is a bit special in that I've come up with a way to detect model arch by how it's pth file looks, but it's not perfect and still means I need to add manual support for new architectures.

And yeah, showing a list of programs that support each model is something we wanted to have but haven't gotten around to implementating yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants